From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 445343A1936E; Thu, 29 Apr 2021 08:40:23 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 445343A1936E
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/100232] [OpenMP][nvptx] Reduction fails with
 optimization and 'loop'/'for simd' but not with 'for'
Date: Thu, 29 Apr 2021 08:40:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: openmp, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-100232-4-Cw9NK2vnLn@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-100232-4@http.gcc.gnu.org/bugzilla/>
References: <bug-100232-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Apr 2021 08:40:23 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100232

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Tom de Vries
<vries@gcc.gnu.org>:

https://gcc.gnu.org/g:f94c6caac7f03815c26c03a532f834c37517519c

commit r11-8324-gf94c6caac7f03815c26c03a532f834c37517519c
Author: Tom de Vries <tdevries@suse.de>
Date:   Wed Apr 28 16:00:01 2021 +0200

    [omp, simt] Fix expand_GOMP_SIMT_*

    When running the test-case included in this patch using an
    nvptx accelerator, it fails in execution.

    The problem is that the expansion of GOMP_SIMT_XCHG_BFLY is optimized a=
way
    during pass_jump as "trivially dead insns".

    This is caused by this code in expand_GOMP_SIMT_XCHG_BFLY:
    ...
      class expand_operand ops[3];
      create_output_operand (&ops[0], target, mode);
      ...
      expand_insn (targetm.code_for_omp_simt_xchg_bfly, 3, ops);
    ...
    which doesn't guarantee that target is assigned to by the expanded insn.

    F.i., if target is:
    ...
    (gdb) call debug_rtx ( target )
    (subreg/s/u:QI (reg:SI 40 [ _61 ]) 0)
    ...
    then after expand_insn, we have:
    ...
    (gdb) call debug_rtx ( ops[0].value )
    (reg:QI 57)
    ...

    See commit 3af3bec2e4d "internal-fn: Avoid dropping the lhs of some
    calls [PR94941]" for a similar problem.

    Fix this in the same way, by adding:
    ...
      if (!rtx_equal_p (target, ops[0].value))
        emit_move_insn (target, ops[0].value);
    ...
    where applicable in the expand_GOMP_SIMT_* functions.

    Tested libgomp on x86_64 with nvptx accelerator.

    gcc/ChangeLog:

    2021-04-28  Tom de Vries  <tdevries@suse.de>

            PR target/100232
            * internal-fn.c (expand_GOMP_SIMT_ENTER_ALLOC)
            (expand_GOMP_SIMT_LAST_LANE, expand_GOMP_SIMT_ORDERED_PRED)
            (expand_GOMP_SIMT_VOTE_ANY, expand_GOMP_SIMT_XCHG_BFLY)
            (expand_GOMP_SIMT_XCHG_IDX): Ensure target is assigned to.

    (cherry picked from commit 4d7c874e2c64ebf7631049ace642d246843febae)=