[Bug libstdc++/100259] New: ODR violations in <experimental/internet>

[Bug libstdc++/100259] New: ODR violations in <experimental/internet>

[aaron at aarongraham dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100259

            Bug ID: 100259
           Summary: ODR violations in <experimental/internet>
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: aaron at aarongraham dot com
  Target Milestone: ---

Current implementation in <experimental/internet> has functions that violate
ODR:

  std::experimental::net::ip::make_error_code
  std::experimental::net::ip::make_error_condition
  std::experimental::net::ip::make_network_v4

It seems these should be inline and/or constexpr. There are probably others.

[Bug libstdc++/100259] ODR violations in <experimental/internet>

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100259

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-04-26
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Aaron Graham from comment #0)
> It seems these should be inline and/or constexpr.

They're not allowed to be constexpr, so have to be inline.

> There are probably others.

Almost certainly.

[Bug libstdc++/100259] ODR violations in <experimental/internet>

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100259

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:3f4aa4579a6c03e0a0b0a6aec68aa5a301264d45

commit r12-120-g3f4aa4579a6c03e0a0b0a6aec68aa5a301264d45
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 26 11:37:38 2021 +0100

    libstdc++: Add missing 'inline' specifiers to net::ip functions [PR 100259]

    libstdc++-v3/ChangeLog:

            PR libstdc++/100259
            * include/experimental/internet (net::ip::make_error_code)
            (net::ip::make_error_condition, net::ip::make_network_v4)
            (net::ip::operator==(const udp&, const udp&)): Add 'inline'.

[Bug libstdc++/100259] ODR violations in <experimental/internet>

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100259

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:4e54a34eed4f941cf09f27245bb3a5bfdb406a16

commit r11-8330-g4e54a34eed4f941cf09f27245bb3a5bfdb406a16
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 26 11:37:38 2021 +0100

    libstdc++: Add missing 'inline' specifiers to net::ip functions [PR 100259]

    libstdc++-v3/ChangeLog:

            PR libstdc++/100259
            * include/experimental/internet (net::ip::make_error_code)
            (net::ip::make_error_condition, net::ip::make_network_v4)
            (net::ip::operator==(const udp&, const udp&)): Add 'inline'.

    (cherry picked from commit 3f4aa4579a6c03e0a0b0a6aec68aa5a301264d45)

[Bug libstdc++/100259] ODR violations in <experimental/internet>

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100259

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:9b6fecd9e594c7342141c334644d3938c8e5fcdb

commit r10-9780-g9b6fecd9e594c7342141c334644d3938c8e5fcdb
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 26 11:37:38 2021 +0100

    libstdc++: Add missing 'inline' specifiers to net::ip functions [PR 100259]

    libstdc++-v3/ChangeLog:

            PR libstdc++/100259
            * include/experimental/internet (net::ip::make_error_code)
            (net::ip::make_error_condition, net::ip::make_network_v4)
            (net::ip::operator==(const udp&, const udp&)): Add 'inline'.

    (cherry picked from commit 3f4aa4579a6c03e0a0b0a6aec68aa5a301264d45)

[Bug libstdc++/100259] ODR violations in <experimental/internet>

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100259

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:75d1d6841dd90649ea03cbe2ec43c3cfb27bebe8

commit r9-9475-g75d1d6841dd90649ea03cbe2ec43c3cfb27bebe8
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 26 11:37:38 2021 +0100

    libstdc++: Add missing 'inline' specifiers to net::ip functions [PR 100259]

    libstdc++-v3/ChangeLog:

            PR libstdc++/100259
            * include/experimental/internet (net::ip::make_error_code)
            (net::ip::make_error_condition, net::ip::make_network_v4)
            (net::ip::operator==(const udp&, const udp&)): Add 'inline'.

    (cherry picked from commit 3f4aa4579a6c03e0a0b0a6aec68aa5a301264d45)

[Bug libstdc++/100259] ODR violations in <experimental/internet>

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100259

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |9.4
             Status|NEW                         |RESOLVED

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed for 9.4, 10.4, 11.2 and trunk (but the networking code is still largely
broken/useless on the old branches and only likely to get fixed on trunk).