[Bug fortran/100273] New: [9/10/11/12 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[Bug fortran/100273] New: [9/10/11/12 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

            Bug ID: 100273
           Summary: [9/10/11/12 Regression] ICE in
                    gfc_create_module_variable, at
                    fortran/trans-decl.c:5352
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started with r7 before 20180426, r6 compiles it :


$ cat z1.f90
module m
   implicit none
contains
   character(4) function g(k)
      integer :: k
      g = f(k)
   contains
      function f(n)
         character(3), parameter :: a(2) = ['1  ', '123']
         integer :: n
         character(len_trim(a(n))) :: f
         f = 'abc'
      end
   end
end
program p
   use m
   print *, '>>' // g(1) // '<<'
   print *, '>>' // g(2) // '<<'
end


$ gfortran-6 -c z1.f90
$
$ gfortran-11-20210425 -c z1.f90
f951: internal compiler error: in gfc_create_module_variable, at
fortran/trans-decl.c:5352
0x75f716 gfc_create_module_variable
        ../../gcc/fortran/trans-decl.c:5350
0x71df02 do_traverse_symtree
        ../../gcc/fortran/symbol.c:4170
0x75fcbb gfc_generate_module_vars(gfc_namespace*)
        ../../gcc/fortran/trans-decl.c:5845
0x73a1f4 gfc_generate_module_code(gfc_namespace*)
        ../../gcc/fortran/trans.c:2307
0x6e6531 translate_all_program_units
        ../../gcc/fortran/parse.c:6342
0x6e6531 gfc_parse_file()
        ../../gcc/fortran/parse.c:6624
0x732d2f gfc_be_parse_file
        ../../gcc/fortran/f95-lang.c:212

[Bug fortran/100273] [9/10/11/12 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-valid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

The following variants can be compiled and work as expected :


$ cat z2.f90
module m
   implicit none
contains
   character(4) function g(k)
      integer :: k
      character(3), parameter :: a(2) = ['1  ', '123']
      g = f(k)
   contains
      function f(n)
         integer :: n
         character(len_trim(a(n))) :: f
         f = 'abc'
      end
   end
end
program p
   use m
   print *, '>>' // g(1) // '<<'
   print *, '>>' // g(2) // '<<'
end


$ cat z3.f90
module m
   implicit none
   character(3), parameter :: a(2) = ['1  ', '123']
contains
   character(4) function g(k)
      integer :: k
      g = f(k)
   contains
      function f(n)
         integer :: n
         character(len_trim(a(n))) :: f
         f = 'abc'
      end
   end
end
program p
   use m
   print *, '>>' // g(1) // '<<'
   print *, '>>' // g(2) // '<<'
end

[Bug fortran/100273] [9/10/11/12 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-04-26
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from anlauf at gcc dot gnu.org ---
Looks very related to the len_trim issue in pr84868.  Possibly a duplicate.

[Bug fortran/100273] [9/10/11/12 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.4
           Priority|P3                          |P4

[Bug fortran/100273] [9/10/11/12 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.4                         |9.5

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9.4 is being released, retargeting bugs to GCC 9.5.

[Bug fortran/100273] [10/11/12/13 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.5                         |10.4

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 9 branch is being closed

[Bug fortran/100273] [10/11/12/13 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.4                        |10.5

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 10.4 is being released, retargeting bugs to GCC 10.5.

[Bug fortran/100273] [11/12/13/14 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug fortran/100273] [11/12/13/14/15 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #7 from anlauf at gcc dot gnu.org ---
(In reply to anlauf from comment #2)
> Looks very related to the len_trim issue in pr84868.  Possibly a duplicate.

After the fix for pr84868, the issue still persists.
Reduced testcase:

module m
  implicit none
  private
contains
  subroutine s()
!   character, parameter :: c(3) = ['*', '+', '-']   ! works when placed here
  contains
    function f(n) result(z)
      integer,  intent(in) :: n
      character, parameter :: c(3) = ['*', '+', '-'] ! ICE when here
      character(len_trim(c(n)))  :: z
      z = c(n)
    end
  end
end

We hit the assert in gfc_create_module_variable:

  gcc_assert (sym->ns->proc_name->attr.flavor == FL_MODULE
              || (sym->ns->parent->proc_name->attr.flavor == FL_MODULE
                  && sym->fn_result_spec));

(gdb) p sym->ns->proc_name->attr.flavor
$1 = FL_PROCEDURE
(gdb) p sym->ns->parent->proc_name->attr.flavor
$2 = FL_PROCEDURE

For the working version from above, one finds:

(gdb) p sym->ns->proc_name->attr.flavor
$3 = FL_PROCEDURE
(gdb) p sym->ns->parent->proc_name->attr.flavor
$4 = FL_MODULE

[Bug fortran/100273] [12/13/14/15 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|11.5                        |12.5

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 11 branch is being closed.

[Bug fortran/100273] [12/13/14/15 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

--- Comment #9 from anlauf at gcc dot gnu.org ---
Patch that fixes the ICE:

diff --git a/gcc/fortran/trans-decl.cc b/gcc/fortran/trans-decl.cc
index 6692ac7ef4c..ee41d66e6d2 100644
--- a/gcc/fortran/trans-decl.cc
+++ b/gcc/fortran/trans-decl.cc
@@ -5540,7 +5540,8 @@ gfc_create_module_variable (gfc_symbol * sym)
   /* Create the variable.  */
   pushdecl (decl);
   gcc_assert (sym->ns->proc_name->attr.flavor == FL_MODULE
-             || (sym->ns->parent->proc_name->attr.flavor == FL_MODULE
+             || ((sym->ns->parent->proc_name->attr.flavor == FL_MODULE
+                  || sym->ns->parent->proc_name->attr.flavor == FL_PROCEDURE)
                  && sym->fn_result_spec));
   DECL_CONTEXT (decl) = sym->ns->proc_name->backend_decl;
   rest_of_decl_compilation (decl, 1, 0);

[Bug fortran/100273] [12/13/14/15 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #10 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2024-September/060949.html

[Bug fortran/100273] [12/13/14/15 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:1f462b5072a5e82c35921f7e3bdf3959c4a49dc9

commit r15-3494-g1f462b5072a5e82c35921f7e3bdf3959c4a49dc9
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 5 21:30:25 2024 +0200

    Fortran: fix ICE in gfc_create_module_variable [PR100273]

    gcc/fortran/ChangeLog:

            PR fortran/100273
            * trans-decl.cc (gfc_create_module_variable): Handle module
            variable also when it is needed for the result specification
            of a contained function.

    gcc/testsuite/ChangeLog:

            PR fortran/100273
            * gfortran.dg/pr100273.f90: New test.

[Bug fortran/100273] [12/13/14 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12/13/14/15 Regression]    |[12/13/14 Regression] ICE
                   |ICE in                      |in
                   |gfc_create_module_variable, |gfc_create_module_variable,
                   |at                          |at
                   |fortran/trans-decl.c:5352   |fortran/trans-decl.c:5352

--- Comment #12 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-15.

[Bug fortran/100273] [12/13/14 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

--- Comment #13 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-14 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:cf8f6aa2a0e4378cec0f9bdbde8cd9a2ea3fb3e5

commit r14-10695-gcf8f6aa2a0e4378cec0f9bdbde8cd9a2ea3fb3e5
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 5 21:30:25 2024 +0200

    Fortran: fix ICE in gfc_create_module_variable [PR100273]

    gcc/fortran/ChangeLog:

            PR fortran/100273
            * trans-decl.cc (gfc_create_module_variable): Handle module
            variable also when it is needed for the result specification
            of a contained function.

    gcc/testsuite/ChangeLog:

            PR fortran/100273
            * gfortran.dg/pr100273.f90: New test.

    (cherry picked from commit 1f462b5072a5e82c35921f7e3bdf3959c4a49dc9)

[Bug fortran/100273] [12/13/14 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

--- Comment #14 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:cb25c5dd6b315dc216c7a5640dc89c5d74ffea34

commit r12-10720-gcb25c5dd6b315dc216c7a5640dc89c5d74ffea34
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 5 21:30:25 2024 +0200

    Fortran: fix ICE in gfc_create_module_variable [PR100273]

    gcc/fortran/ChangeLog:

            PR fortran/100273
            * trans-decl.cc (gfc_create_module_variable): Handle module
            variable also when it is needed for the result specification
            of a contained function.

    gcc/testsuite/ChangeLog:

            PR fortran/100273
            * gfortran.dg/pr100273.f90: New test.

    (cherry picked from commit 1f462b5072a5e82c35921f7e3bdf3959c4a49dc9)

[Bug fortran/100273] [12/13/14 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:3604d9cab9bb9fe6a3c642385c816211b8f2be5d

commit r13-9048-g3604d9cab9bb9fe6a3c642385c816211b8f2be5d
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Thu Sep 5 21:30:25 2024 +0200

    Fortran: fix ICE in gfc_create_module_variable [PR100273]

    gcc/fortran/ChangeLog:

            PR fortran/100273
            * trans-decl.cc (gfc_create_module_variable): Handle module
            variable also when it is needed for the result specification
            of a contained function.

    gcc/testsuite/ChangeLog:

            PR fortran/100273
            * gfortran.dg/pr100273.f90: New test.

    (cherry picked from commit 1f462b5072a5e82c35921f7e3bdf3959c4a49dc9)

[Bug fortran/100273] [12/13/14 Regression] ICE in gfc_create_module_variable, at fortran/trans-decl.c:5352

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100273

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #16 from anlauf at gcc dot gnu.org ---
Fixed on all open branches.  Closing.

Thanks for the report!