public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/100350] New: [12 Regression] x86-64→PowerPC bootstrap fails since r12-228:  error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN'
@ 2021-04-30  9:24 burnus at gcc dot gnu.org
  2021-04-30 10:05 ` [Bug bootstrap/100350] " burnus at gcc dot gnu.org
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-04-30  9:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100350

            Bug ID: 100350
           Summary: [12 Regression] x86-64→PowerPC bootstrap fails since
                    r12-228:  error: '__LIBGCC_KF_MIN__' undeclared in
                    expansion of macro 'RMIN'
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Keywords: build
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: dje at gcc dot gnu.org, jemarch at gnu dot org, segher at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-gnu-linux
            Target: powerpc64le-linux

The crossbuild x86-64-gnu-linux to powerpc64le-linux now fails with the
following error.

The commit causing this issue is:
  r12-228-g54f0224d55a1b56dde092460ddf76913670e6efc
  "Practical improvement to libgcc complex divide"
  Author:     Patrick McGehearty <patrick.mcgehearty@oracle.com>
  Commit:     Jose E. Marchesi <jose.marchesi@oracle.com>
  Date:       Wed Apr 28 21:54:44 2021 +0200

That patch adds to libgcc/config/rs6000/_divkc3.c

+#ifndef __LONG_DOUBLE_IEEE128__
+#define RBIG   (__LIBGCC_KF_MAX__ / 2)
+#define RMIN   (__LIBGCC_KF_MIN__)


The actual fail is:

$BUILD/./gcc/xgcc -B$BUILD/./gcc/ -B$INST/powerpc64le-none-linux-gnu/bin/
-B$INST/powerpc64le-none-linux-gnu/lib/ -isystem
$INST/powerpc64le-none-linux-gnu/include -isystem
$INST/powerpc64le-none-linux-gnu/sys-include
--sysroot=$INST/powerpc64le-none-linux-gnu/libc   -g -O2 -O2  -g -O2 -DIN_GCC 
-DCROSS_DIRECTORY_STRUCTURE  -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wno-format -Wstrict-prototypes -Wmissing-prototypes
-Wold-style-definition  -isystem ./include   -fPIC -mlong-double-128
-mno-minimal-toc -g -DIN_LIBGCC2 -fbuilding-libgcc -fno-stack-protector   -fPIC
-mlong-double-128 -mno-minimal-toc -I. -I. -I../.././gcc -I$SRC/libgcc
-I$SRC/libgcc/. -I$SRC/libgcc/../gcc -I$SRC/libgcc/../include
-I$SRC/libgcc/../libdecnumber/dpd -I$SRC/libgcc/../libdecnumber -DHAVE_CC_TLS 
-o unwind-dw2.o -MT unwind-dw2.o -MD -MP -MF unwind-dw2.dep -fexceptions -c
$SRC/libgcc/unwind-dw2.c -fvisibility=hidden -DHIDE_EXPORTS
$SRC/libgcc/config/rs6000/_divkc3.c:42:17: error: '__LIBGCC_KF_MIN__'
undeclared (first use in this function)
   42 | #define RMIN   (__LIBGCC_KF_MIN__)
      |                 ^~~~~~~~~~~~~~~~~
$SRC/libgcc/config/rs6000/_divkc3.c:87:28: note: in expansion of macro 'RMIN'
   87 |           if (((FABS (a) < RMIN) && (FABS (b) < RMAX2) && (FABS (d) <
RMAX2))
      |                            ^~~~
$SRC/libgcc/shared-object.mk:14: recipe for target '_divkc3.o' failed
make[2]: *** [_divkc3.o] Error 1

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug bootstrap/100350] [12 Regression] x86-64→PowerPC bootstrap fails since r12-228:  error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN'
  2021-04-30  9:24 [Bug bootstrap/100350] New: [12 Regression] x86-64→PowerPC bootstrap fails since r12-228: error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN' burnus at gcc dot gnu.org
@ 2021-04-30 10:05 ` burnus at gcc dot gnu.org
  2021-04-30 10:10 ` burnus at gcc dot gnu.org
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-04-30 10:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100350

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |meissner at gcc dot gnu.org

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Related:
  PR100327 – [12 regression] bootstrap failure after r12-228
with thread starting at
https://gcc.gnu.org/pipermail/gcc-patches/2021-April/569217.html

I thought that I had seen a PR related to this, but could not find it.
Well, the other PR was closed as FIXED with the comment:
  Patch committed on April 29th, 2021.

But I do not see a commit and it still fails.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug bootstrap/100350] [12 Regression] x86-64→PowerPC bootstrap fails since r12-228:  error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN'
  2021-04-30  9:24 [Bug bootstrap/100350] New: [12 Regression] x86-64→PowerPC bootstrap fails since r12-228: error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN' burnus at gcc dot gnu.org
  2021-04-30 10:05 ` [Bug bootstrap/100350] " burnus at gcc dot gnu.org
@ 2021-04-30 10:10 ` burnus at gcc dot gnu.org
  2021-04-30 11:58 ` rguenth at gcc dot gnu.org
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-04-30 10:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100350

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Tobias Burnus from comment #1)
>   Patch committed on April 29th, 2021.

I think that's in another email thread - which also does not show the PR in the
subject line,
those email thread starts at:

  https://gcc.gnu.org/pipermail/gcc-patches/2021-April/569238.html
  "[PATCH, V2] Define KFmode constants for libgcc."

That patch was approved with comments, but not yet committed. Let's see whether
yet another email thread will pop up ...

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug bootstrap/100350] [12 Regression] x86-64→PowerPC bootstrap fails since r12-228:  error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN'
  2021-04-30  9:24 [Bug bootstrap/100350] New: [12 Regression] x86-64→PowerPC bootstrap fails since r12-228: error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN' burnus at gcc dot gnu.org
  2021-04-30 10:05 ` [Bug bootstrap/100350] " burnus at gcc dot gnu.org
  2021-04-30 10:10 ` burnus at gcc dot gnu.org
@ 2021-04-30 11:58 ` rguenth at gcc dot gnu.org
  2021-04-30 16:35 ` burnus at gcc dot gnu.org
  2021-05-01  8:19 ` burnus at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-04-30 11:58 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100350

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
           Priority|P3                          |P1
            Version|11.0                        |12.0

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug bootstrap/100350] [12 Regression] x86-64→PowerPC bootstrap fails since r12-228:  error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN'
  2021-04-30  9:24 [Bug bootstrap/100350] New: [12 Regression] x86-64→PowerPC bootstrap fails since r12-228: error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN' burnus at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2021-04-30 11:58 ` rguenth at gcc dot gnu.org
@ 2021-04-30 16:35 ` burnus at gcc dot gnu.org
  2021-05-01  8:19 ` burnus at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-04-30 16:35 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100350

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The master branch has been updated by Michael Meissner <meissner@gcc.gnu.org>:

https://gcc.gnu.org/g:d9398dd2902a0142fa3b493cf61a340f1f5ab46f

commit r12-325-gd9398dd2902a0142fa3b493cf61a340f1f5ab46f
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Fri Apr 30 12:32:08 2021 -0400

    Define target hook to emit KFmode constants for libgcc.

    This patch defines a target hook so that the KFmode constants
    (__LIBGCC_KF_MAX__, __LIBGCC_KF_MIN__, and __LIBGCC_KF_EPSILON__) needed to
    build _divkc3.c in libgcc are defined.  The need for these constants were
added
    in the April 28th changes to libgcc that added complex division
optimizations.

    We only define the KFmode constants if IEEE 128-bit floating point is
    supported, but long double does not use the IEEE 128-bit format.  If long
    double uses the IEEE 128-bit format, it will use TFmode and not KFmode.

    gcc/
    2021-04-30  Michael Meissner  <meissner@linux.ibm.com>

            PR bootstrap/100327
            * config/rs6000/rs6000.c
            (TARGET_LIBGCC_FLOATING_MODE_SUPPORTED_P): Define.
            (rs6000_libgcc_floating_mode_supported_p): New target hook.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Bug bootstrap/100350] [12 Regression] x86-64→PowerPC bootstrap fails since r12-228:  error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN'
  2021-04-30  9:24 [Bug bootstrap/100350] New: [12 Regression] x86-64→PowerPC bootstrap fails since r12-228: error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN' burnus at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2021-04-30 16:35 ` burnus at gcc dot gnu.org
@ 2021-05-01  8:19 ` burnus at gcc dot gnu.org
  4 siblings, 0 replies; 6+ messages in thread
From: burnus at gcc dot gnu.org @ 2021-05-01  8:19 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100350

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Close as FIXED.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-05-01  8:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30  9:24 [Bug bootstrap/100350] New: [12 Regression] x86-64→PowerPC bootstrap fails since r12-228: error: '__LIBGCC_KF_MIN__' undeclared in expansion of macro 'RMIN' burnus at gcc dot gnu.org
2021-04-30 10:05 ` [Bug bootstrap/100350] " burnus at gcc dot gnu.org
2021-04-30 10:10 ` burnus at gcc dot gnu.org
2021-04-30 11:58 ` rguenth at gcc dot gnu.org
2021-04-30 16:35 ` burnus at gcc dot gnu.org
2021-05-01  8:19 ` burnus at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).