public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "vgupta at synopsys dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/100363] New: gcc generating wider load/store than warranted at -O3 Date: Fri, 30 Apr 2021 20:09:42 +0000 [thread overview] Message-ID: <bug-100363-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100363 Bug ID: 100363 Summary: gcc generating wider load/store than warranted at -O3 Product: gcc Version: 10.2.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: vgupta at synopsys dot com Target Milestone: --- Created attachment 50722 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50722&action=edit test case with an additional nop to annotate codegen In Linux kernel's initramfs gzip inflate code, an inner copy loop using unsigned short pointers (src/dst) is generated with wider 8 or 16-byte at a time (vs. 2 bytes at a time) causing extra/unintended bytes to be copied - leading to corruption of inflated files on target. The showed up on upstream v5.6 Linux kernel built for ARC (defaults to -O3). Issue doesn't happen at -O2. Full test case attached, but the gist of it is: lib/zlib_inflate/inffast.c if (dist > 2) { unsigned short *sfrom; sfrom = (unsigned short *)(from); loops = len >> 1; do *sout++ = *sfrom++; while (--loops); out = (unsigned char *)sout; from = (unsigned char *)sfrom; } ... @sfrom and @sout are unsigned short pointers and thus expected to work on 2 bytes. However at -O3 gcc is generating wide loads (8-byte LDD/STD on ARCv2, 16-byte LDR q0 on aarch64. For aarch64, it seems there's code generated for 16-byte access as well as 2-byte, and I haven't verified if it elides the 16-byte code based on size etc - but the code is generated nonetheless. For ARC 8-byte loop is certainly executed causing bad things as described The issue was originally seen with mainline gcc 10.2 (again both ARC and aarch64) at -O3 and I can confirm it exists in gcc 9.3 as well. Attaching preprocessed source file is from ARC linux build (but builds for aarch64 too since non of arch specific functions are used here.
next reply other threads:[~2021-04-30 20:09 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-30 20:09 vgupta at synopsys dot com [this message] 2021-04-30 21:43 ` [Bug middle-end/100363] " pinskia at gcc dot gnu.org 2021-04-30 21:44 ` pinskia at gcc dot gnu.org 2021-04-30 21:56 ` vgupta at synopsys dot com 2021-04-30 22:02 ` torvalds@linux-foundation.org 2021-04-30 22:19 ` [Bug tree-optimization/100363] " pinskia at gcc dot gnu.org 2021-04-30 22:20 ` pinskia at gcc dot gnu.org 2021-04-30 22:33 ` vgupta at synopsys dot com 2021-05-01 22:54 ` amonakov at gcc dot gnu.org 2021-05-01 23:09 ` torvalds@linux-foundation.org 2021-05-03 7:41 ` rguenth at gcc dot gnu.org 2021-05-03 16:03 ` torvalds@linux-foundation.org 2021-05-03 16:18 ` torvalds@linux-foundation.org 2021-05-03 17:25 ` vgupta at synopsys dot com 2021-05-03 17:28 ` vgupta at synopsys dot com 2021-05-03 17:47 ` torvalds@linux-foundation.org 2021-05-03 18:45 ` vgupta at synopsys dot com 2021-05-03 19:43 ` pinskia at gcc dot gnu.org 2021-05-04 6:24 ` rguenth at gcc dot gnu.org 2021-05-04 19:33 ` vgupta at synopsys dot com 2021-05-05 6:32 ` rguenther at suse dot de 2021-05-05 19:59 ` ndesaulniers at google dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100363-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).