From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id B3D39386FC26; Tue,  4 May 2021 07:39:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3D39386FC26
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/100366] spurious warning - std::vector::clear
 followed by std::vector::insert(vec.end(), ...) with -O2
Date: Tue, 04 May 2021 07:39:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 11.1.0
X-Bugzilla-Keywords: diagnostic, missed-optimization
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-100366-4-UcjslSBleH@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-100366-4@http.gcc.gnu.org/bugzilla/>
References: <bug-100366-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 04 May 2021 07:39:35 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100366

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
The issue is that FRE sees

  <bb 2> [local count: 1073741824]:
  _6 =3D vec_2(D)->D.33436._M_impl.D.32749._M_start;
  _7 =3D vec_2(D)->D.33436._M_impl.D.32749._M_finish;
  if (_6 !=3D _7)
    goto <bb 3>; [70.00%]
  else
    goto <bb 4>; [30.00%]

  <bb 3> [local count: 751619281]:
  vec_2(D)->D.33436._M_impl.D.32749._M_finish =3D _6;

  <bb 4> [local count: 1073741824]:
  _5 =3D MEM[(char * const &)vec_2(D) + 8];

so clearly _5 is _not_ equal to _7 but on the path 2 -> 3 -> 4 it is equal =
to
_6.
Only PRE transforms the load in _5 to a select of both (a PHI node):

  <bb 2> [local count: 1073741824]:
  _6 =3D vec_2(D)->D.33436._M_impl.D.32749._M_start;
  _7 =3D vec_2(D)->D.33436._M_impl.D.32749._M_finish;
  if (_6 !=3D _7)
    goto <bb 4>; [70.00%]
  else
    goto <bb 3>; [30.00%]

  <bb 3> [local count: 322122544]:
  _86 =3D _7 - _6;
  _125 =3D (sizetype) _86;
  goto <bb 5>; [100.00%]

  <bb 4> [local count: 751619281]:
  vec_2(D)->D.33436._M_impl.D.32749._M_finish =3D _6;

  <bb 5> [local count: 1073741824]:
  # prephitmp_141 =3D PHI <_7(3), _6(4)>
  # prephitmp_83 =3D PHI <_86(3), 0(4)>
  # prephitmp_65 =3D PHI <_125(3), 0(4)>
  _21 =3D vec_2(D)->D.33436._M_impl.D.32749._M_end_of_storage;

PRE also removes some partial redundancies here (the other two PHIs).=