[Bug target/100375] New: [12 Regression] trunk 20210501 ftbfs for nvptx-none

[Bug target/100375] New: [12 Regression] trunk 20210501 ftbfs for nvptx-none

[doko at debian dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

            Bug ID: 100375
           Summary: [12 Regression] trunk 20210501 ftbfs for nvptx-none
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at debian dot org
  Target Milestone: ---

trunk 20210501 ftbfs for nvptx-none, trying to build the offload compiler with
the just built trunk 20210501 x86_64-linux-gnu host build.

../../src-nvptx/gcc/config/nvptx/nvptx.c: In function 'void
nvptx_sese_pseudo(basic_block, bb_sese*, int, int, vec<e
dge_def*, va_gc>*, size_t)':
../../src-nvptx/gcc/config/nvptx/nvptx.c:3754:42: error: call of overloaded
'pair(int, int)' is ambiguous
 3754 |           node_back = pseudo_node_t (0, 0);
      |                                          ^
In file included from
/packages/gcc/snap/gcc-snapshot-20210501/build/x86_64-linux-gnu/libstdc++-v3/include/bits/stl_algobase.h:64,
                 from
/packages/gcc/snap/gcc-snapshot-20210501/build/x86_64-linux-gnu/libstdc++-v3/include/bits/char_traits.h:39,
                 from
/packages/gcc/snap/gcc-snapshot-20210501/build/x86_64-linux-gnu/libstdc++-v3/include/ios:40,
                 from
/packages/gcc/snap/gcc-snapshot-20210501/build/x86_64-linux-gnu/libstdc++-v3/include/istream:38,
                 from
/packages/gcc/snap/gcc-snapshot-20210501/build/x86_64-linux-gnu/libstdc++-v3/include/sstream:38,

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
r12-220-gd96db15967e78d7cecea3b1cf3169ceb924678ac ?

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
What type is pseudo_node_t? If the pair members are pointers, use nullptr not
0.

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
typedef struct basic_block_def *basic_block;
typedef std::pair<basic_block, int> pseudo_node_t;

So pseudo_node_t (nullptr, 0);
or pseudo_node_t (NULL, 0);
(given
#ifdef __cplusplus
#undef NULL
#define NULL nullptr
#endif
)?

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
constructing pair<T*, int> using (0, 0) is non-standard. The point of r12-220
was to deprecate it, so it warns. Apparently I didn't manage to do that
correctly.

I'll look into that, but if you want to initialize a pointer when templates are
involved (which is the case for std::pair's constructors) then don't use 0.

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:7911a905276781c20f704f5a91b5125e0184d072

commit r12-343-g7911a905276781c20f704f5a91b5125e0184d072
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sun May 2 14:17:23 2021 +0200

    nvptx: Fix up nvptx build against latest libstdc++ [PR100375]

    The r12-220-gd96db15967e78d7cecea3b1cf3169ceb924678ac change
    deprecated some non-standard std::pair constructors and that apparently
    broke nvptx.c build, where pseudo_node_t is std::pair<struct
basic_block_def *, int>
    and so nullptr (or NULL) needs to be used for the first argument of the
    ctors instead of 0.

    2021-05-02  Jakub Jelinek  <jakub@redhat.com>

            PR target/100375
            * config/nvptx/nvptx.c (nvptx_sese_pseudo): Use nullptr instead of
0
            as first argument of pseudo_node_t constructors.

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0
            Version|11.0                        |12.0
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I need to fix libstdc++ to accept the code with a deprecated warning, rather
than reject it. I think it only rejects it with -pedantic but it should still
be fixed to work until the deprecated constructor is removed.

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:da9c085ddbfe61e5954c8ec4e996240fa3a994c0

commit r11-8346-gda9c085ddbfe61e5954c8ec4e996240fa3a994c0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sun May 2 14:17:23 2021 +0200

    nvptx: Fix up nvptx build against latest libstdc++ [PR100375]

    The r12-220-gd96db15967e78d7cecea3b1cf3169ceb924678ac change
    deprecated some non-standard std::pair constructors and that apparently
    broke nvptx.c build, where pseudo_node_t is std::pair<struct
basic_block_def *, int>
    and so nullptr (or NULL) needs to be used for the first argument of the
    ctors instead of 0.

    2021-05-02  Jakub Jelinek  <jakub@redhat.com>

            PR target/100375
            * config/nvptx/nvptx.c (nvptx_sese_pseudo): Use nullptr instead of
0
            as first argument of pseudo_node_t constructors.

    (cherry picked from commit 7911a905276781c20f704f5a91b5125e0184d072)

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:a0f9800f389bae0f3f311844cdc8fc91156e8718

commit r10-9795-ga0f9800f389bae0f3f311844cdc8fc91156e8718
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sun May 2 14:17:23 2021 +0200

    nvptx: Fix up nvptx build against latest libstdc++ [PR100375]

    The r12-220-gd96db15967e78d7cecea3b1cf3169ceb924678ac change
    deprecated some non-standard std::pair constructors and that apparently
    broke nvptx.c build, where pseudo_node_t is std::pair<struct
basic_block_def *, int>
    and so nullptr (or NULL) needs to be used for the first argument of the
    ctors instead of 0.

    2021-05-02  Jakub Jelinek  <jakub@redhat.com>

            PR target/100375
            * config/nvptx/nvptx.c (nvptx_sese_pseudo): Use NULL instead of 0
            as first argument of pseudo_node_t constructors.

    (cherry picked from commit 7911a905276781c20f704f5a91b5125e0184d072)

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:af08d7265bb5a82f3728737476c8098458a8d210

commit r9-9507-gaf08d7265bb5a82f3728737476c8098458a8d210
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sun May 2 14:17:23 2021 +0200

    nvptx: Fix up nvptx build against latest libstdc++ [PR100375]

    The r12-220-gd96db15967e78d7cecea3b1cf3169ceb924678ac change
    deprecated some non-standard std::pair constructors and that apparently
    broke nvptx.c build, where pseudo_node_t is std::pair<struct
basic_block_def *, int>
    and so nullptr (or NULL) needs to be used for the first argument of the
    ctors instead of 0.

    2021-05-02  Jakub Jelinek  <jakub@redhat.com>

            PR target/100375
            * config/nvptx/nvptx.c (nvptx_sese_pseudo): Use NULL instead of 0
            as first argument of pseudo_node_t constructors.

    (cherry picked from commit 7911a905276781c20f704f5a91b5125e0184d072)

[Bug target/100375] [12 Regression] trunk 20210501 ftbfs for nvptx-none

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100375

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-8 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0d7e8e713c5b20141de02f9c4fb11e77c2f66484

commit r8-10948-g0d7e8e713c5b20141de02f9c4fb11e77c2f66484
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sun May 2 14:17:23 2021 +0200

    nvptx: Fix up nvptx build against latest libstdc++ [PR100375]

    The r12-220-gd96db15967e78d7cecea3b1cf3169ceb924678ac change
    deprecated some non-standard std::pair constructors and that apparently
    broke nvptx.c build, where pseudo_node_t is std::pair<struct
basic_block_def *, int>
    and so nullptr (or NULL) needs to be used for the first argument of the
    ctors instead of 0.

    2021-05-02  Jakub Jelinek  <jakub@redhat.com>

            PR target/100375
            * config/nvptx/nvptx.c (nvptx_sese_pseudo): Use NULL instead of 0
            as first argument of pseudo_node_t constructors.

    (cherry picked from commit 7911a905276781c20f704f5a91b5125e0184d072)