public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/100431] Fixes to enable compiling with -Werror=format-security
Date: Wed, 05 May 2021 11:47:37 +0000	[thread overview]
Message-ID: <bug-100431-4-VGLXaAaaXp@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100431-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100431

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Comment on attachment 50757
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50757
Patch to fix -Werror=format-security errors

I doubt you have properly tested it, because it is clearly buggy.

          const char *message = (result & CPP_N_UNSIGNED) == CPP_N_UNSIGNED
                                ? N_("use of C++23 %<size_t%> integer
constant")
                                : N_("use of C++23 %<make_signed_t<size_t>%>
integer constant");
          cpp_warning_with_line (pfile, CPP_W_SIZE_T_LITERALS,
                                 virtual_location, 0, message);
Changing this to "%s", message obviously breaks it, it will not print
use of C++23 'size_t' integer constant (or with UTF-8 quotes etc. and with
colors etc.), but
use of C++23 %<size_t%> integer constant

  parent reply	other threads:[~2021-05-05 11:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 11:24 [Bug bootstrap/100431] New: " joey.dumont at gmail dot com
2021-05-05 11:25 ` [Bug bootstrap/100431] " joey.dumont at gmail dot com
2021-05-05 11:47 ` jakub at gcc dot gnu.org [this message]
2021-05-11 13:45 ` joey.dumont at gmail dot com
2021-05-11 13:57 ` jakub at gcc dot gnu.org
2021-06-20  2:33 ` joey.dumont at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100431-4-VGLXaAaaXp@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).