public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/100444] std::random_device isn't random on AMD Date: Thu, 06 May 2021 08:58:49 +0000 [thread overview] Message-ID: <bug-100444-4-LbBOwQ98nR@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-100444-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100444 --- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> --- So at least libstdc++ does check RDRAND availability via cpuid. It also already checks the return value for "no avaialble randomness": while (__builtin_ia32_rdrand32_step(&val) == 0) if (--retries == 0) std::__throw_runtime_error(__N("random_device: rdrand failed")); so here it could check for -1 as well though in theory that can happen with true randomness as well, even if very unlikely. Note that it would never return -1 then (as it never returns 0 at the moment). Thus I believe the issue is mitigated at the kernel level and people that cannot be bothered to update their ucode or the kernel are not likely bothered to update libstdc++ either. Note handling it above would raise a runtime error rather than falling back to other sources of randomness. Doing the checking where we detect rdrand support would avoid that.
next prev parent reply other threads:[~2021-05-06 8:58 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-06 7:45 [Bug libstdc++/100444] New: " ecree429 at virginmedia dot com 2021-05-06 7:52 ` [Bug libstdc++/100444] " rguenth at gcc dot gnu.org 2021-05-06 8:48 ` ecree429 at virginmedia dot com 2021-05-06 8:49 ` pinskia at gcc dot gnu.org 2021-05-06 8:58 ` rguenth at gcc dot gnu.org [this message] 2021-05-06 10:05 ` redi at gcc dot gnu.org 2021-05-06 10:22 ` redi at gcc dot gnu.org 2021-05-06 10:51 ` ecree429 at virginmedia dot com 2021-05-06 11:25 ` redi at gcc dot gnu.org 2021-05-06 11:39 ` rguenth at gcc dot gnu.org 2021-05-06 11:41 ` redi at gcc dot gnu.org 2021-05-10 20:20 ` redi at gcc dot gnu.org 2021-05-13 18:46 ` ecree429 at virginmedia dot com 2021-05-14 9:23 ` redi at gcc dot gnu.org 2021-09-25 20:07 ` redi at gcc dot gnu.org 2021-10-04 12:20 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100444-4-LbBOwQ98nR@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).