public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/100485] False positive in -Wmismatched-new-delete
Date: Sun, 09 May 2021 22:04:42 +0000	[thread overview]
Message-ID: <bug-100485-4-VJJRikqxO8@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100485-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100485

--- Comment #4 from Martin Sebor <msebor at gcc dot gnu.org> ---
-Wmismatched-new-delete considers only "mismatches between calls to operator
new or operator delete and the corresponding call to the allocation or
deallocation function."  It doesn't also consider attribute malloc, by design. 
It would be possible, even easy, to change that and have the warning also look
for attribute malloc to handle this case but it doesn't seem like a good design
feature to me to provide support for associating a member operator new() with
an unrelated deallocation function, whether it's free() or another operator
delete().  To do that, I would instead suggest suppressing the warning by using
#pragma GCC diagnostic ignored "-Wmismatched-new-delete":

extern "C" void free (void *);

class Base
{
public:
        Base();

        void * operator new(unsigned long, const int &);
        void operator delete(void * ptr, const int &) {
          #pragma GCC diagnostic ignored "-Wmismatched-new-delete"
          free (ptr);
        }
};

void f()
{
        new (0) Base;
}

  parent reply	other threads:[~2021-05-09 22:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08  9:32 [Bug c++/100485] New: " fiesh at zefix dot tv
2021-05-09 17:49 ` [Bug c++/100485] " msebor at gcc dot gnu.org
2021-05-09 18:05 ` fiesh at zefix dot tv
2021-05-09 18:06 ` fiesh at zefix dot tv
2021-05-09 22:04 ` msebor at gcc dot gnu.org [this message]
2021-05-10  6:53 ` fiesh at zefix dot tv
2021-05-10 14:39 ` msebor at gcc dot gnu.org
2021-05-10 14:45 ` fiesh at zefix dot tv
2021-06-16 22:55 ` msebor at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100485-4-VJJRikqxO8@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).