* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
@ 2021-05-12 7:12 ` rguenth at gcc dot gnu.org
2021-05-12 9:41 ` marxin at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-05-12 7:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |11.2
Priority|P3 |P4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
2021-05-12 7:12 ` [Bug fortran/100551] " rguenth at gcc dot gnu.org
@ 2021-05-12 9:41 ` marxin at gcc dot gnu.org
2021-05-12 20:22 ` anlauf at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-05-12 9:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-05-12
Status|UNCONFIRMED |NEW
CC| |marxin at gcc dot gnu.org,
| |pault at gcc dot gnu.org
Ever confirmed|0 |1
--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r11-6928-g4225af228b5d52e8.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
2021-05-12 7:12 ` [Bug fortran/100551] " rguenth at gcc dot gnu.org
2021-05-12 9:41 ` marxin at gcc dot gnu.org
@ 2021-05-12 20:22 ` anlauf at gcc dot gnu.org
2021-05-12 21:11 ` anlauf at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-05-12 20:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |wrong-code
CC| |anlauf at gcc dot gnu.org
--- Comment #2 from anlauf at gcc dot gnu.org ---
(In reply to Martin Liška from comment #1)
> Started with r11-6928-g4225af228b5d52e8.
The partial revert:
diff --git a/gcc/fortran/trans-expr.c b/gcc/fortran/trans-expr.c
index cce18d094a6..91efb67ac87 100644
--- a/gcc/fortran/trans-expr.c
+++ b/gcc/fortran/trans-expr.c
@@ -5826,7 +5826,8 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym,
&derived_array);
}
else if (UNLIMITED_POLY (fsym) && e->ts.type != BT_CLASS
- && gfc_expr_attr (e).flavor != FL_PROCEDURE)
+// && gfc_expr_attr (e).flavor != FL_PROCEDURE)
+ )
{
/* The intrinsic type needs to be converted to a temporary
CLASS object for the unlimited polymorphic formal. */
fixes this issue but breaks testcase proc_ptr_52.f90.
Further reduced testcase for this PR:
program p
implicit none
integer :: result
result = 1
! result = test ( (result)) ! works
result = test (int (result)) ! fails
write(*,*) result
contains
integer function test(x)
class(*), intent(in) :: x
select type (x)
type is (integer)
test = x
class default
test = -1
end select
end function test
end program
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
` (2 preceding siblings ...)
2021-05-12 20:22 ` anlauf at gcc dot gnu.org
@ 2021-05-12 21:11 ` anlauf at gcc dot gnu.org
2021-05-13 7:41 ` anlauf at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-05-12 21:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
--- Comment #3 from anlauf at gcc dot gnu.org ---
Below fixes this PR and does not break the other testcase:
diff --git a/gcc/fortran/trans-expr.c b/gcc/fortran/trans-expr.c
index cce18d094a6..ebc9ea42beb 100644
--- a/gcc/fortran/trans-expr.c
+++ b/gcc/fortran/trans-expr.c
@@ -5826,7 +5826,8 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym,
&derived_array);
}
else if (UNLIMITED_POLY (fsym) && e->ts.type != BT_CLASS
- && gfc_expr_attr (e).flavor != FL_PROCEDURE)
+ && (gfc_expr_attr (e).flavor != FL_PROCEDURE
+ || gfc_expr_attr (e).proc == PROC_INTRINSIC))
{
/* The intrinsic type needs to be converted to a temporary
CLASS object for the unlimited polymorphic formal. */
I would hope that Paul can explain why this works, or if this is the right
thing.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
` (3 preceding siblings ...)
2021-05-12 21:11 ` anlauf at gcc dot gnu.org
@ 2021-05-13 7:41 ` anlauf at gcc dot gnu.org
2021-05-20 21:30 ` anlauf at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-05-13 7:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
--- Comment #4 from anlauf at gcc dot gnu.org ---
Playing with the testcase show that the patch in comment#3 is incomplete.
Next try:
diff --git a/gcc/fortran/trans-expr.c b/gcc/fortran/trans-expr.c
index cce18d094a6..3de53009970 100644
--- a/gcc/fortran/trans-expr.c
+++ b/gcc/fortran/trans-expr.c
@@ -5826,7 +5826,9 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym,
&derived_array);
}
else if (UNLIMITED_POLY (fsym) && e->ts.type != BT_CLASS
- && gfc_expr_attr (e).flavor != FL_PROCEDURE)
+ && e->ts.type != BT_PROCEDURE
+ && (gfc_expr_attr (e).flavor != FL_PROCEDURE
+ || (gfc_expr_attr (e).proc != PROC_UNKNOWN)))
{
/* The intrinsic type needs to be converted to a temporary
CLASS object for the unlimited polymorphic formal. */
This makes the following case work again:
program p
implicit none
integer :: result
result = 1
result = test ( (result)) ! works
if (result /= 1) stop 1
result = test (int (result)) ! issue 1
write(*,*) result
result = test (f (result)) ! issue 2
write(*,*) result
contains
integer function test(x)
class(*), intent(in) :: x
select type (x)
type is (integer)
test = x
class default
test = -1
end select
end function test
integer function f(x)
integer, intent(in) :: x
f = 2*x
end function f
end program
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
` (4 preceding siblings ...)
2021-05-13 7:41 ` anlauf at gcc dot gnu.org
@ 2021-05-20 21:30 ` anlauf at gcc dot gnu.org
2021-05-23 18:52 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-05-20 21:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |anlauf at gcc dot gnu.org
--- Comment #5 from anlauf at gcc dot gnu.org ---
Patch: https://gcc.gnu.org/pipermail/fortran/2021-May/056071.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
` (5 preceding siblings ...)
2021-05-20 21:30 ` anlauf at gcc dot gnu.org
@ 2021-05-23 18:52 ` cvs-commit at gcc dot gnu.org
2021-05-25 20:13 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-05-23 18:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:fe03f4fc9548b3fdbff3c8284a994feaa7d6307d
commit r12-1005-gfe03f4fc9548b3fdbff3c8284a994feaa7d6307d
Author: Harald Anlauf <anlauf@gmx.de>
Date: Sun May 23 20:51:14 2021 +0200
Fortran: fix passing return value to class(*) dummy argument
gcc/fortran/ChangeLog:
PR fortran/100551
* trans-expr.c (gfc_conv_procedure_call): Adjust check for
implicit conversion of actual argument to an unlimited polymorphic
procedure argument.
gcc/testsuite/ChangeLog:
PR fortran/100551
* gfortran.dg/pr100551.f90: New test.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
` (6 preceding siblings ...)
2021-05-23 18:52 ` cvs-commit at gcc dot gnu.org
@ 2021-05-25 20:13 ` cvs-commit at gcc dot gnu.org
2021-05-25 20:16 ` anlauf at gcc dot gnu.org
2022-01-07 17:47 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-05-25 20:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:de55a48960d2f08266cba1222e233507015dd620
commit r11-8469-gde55a48960d2f08266cba1222e233507015dd620
Author: Harald Anlauf <anlauf@gmx.de>
Date: Sun May 23 20:51:14 2021 +0200
Fortran: fix passing return value to class(*) dummy argument
gcc/fortran/ChangeLog:
PR fortran/100551
* trans-expr.c (gfc_conv_procedure_call): Adjust check for
implicit conversion of actual argument to an unlimited polymorphic
procedure argument.
gcc/testsuite/ChangeLog:
PR fortran/100551
* gfortran.dg/pr100551.f90: New test.
(cherry picked from commit fe03f4fc9548b3fdbff3c8284a994feaa7d6307d)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
` (7 preceding siblings ...)
2021-05-25 20:13 ` cvs-commit at gcc dot gnu.org
@ 2021-05-25 20:16 ` anlauf at gcc dot gnu.org
2022-01-07 17:47 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-05-25 20:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-12 and on 11-branch. Closing.
Thanks for the report!
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/100551] [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults
2021-05-11 21:32 [Bug fortran/100551] New: [11/12 Regression] Passing return value of intrinsic to class(*) dummy argument can cause segfaults bugs at colin dot moe
` (8 preceding siblings ...)
2021-05-25 20:16 ` anlauf at gcc dot gnu.org
@ 2022-01-07 17:47 ` cvs-commit at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-01-07 17:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100551
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:6a3018a4064b39a418d95c32e45fe7d6ad17ebf3
commit r10-10384-g6a3018a4064b39a418d95c32e45fe7d6ad17ebf3
Author: Harald Anlauf <anlauf@gmx.de>
Date: Sun May 23 20:51:14 2021 +0200
Fortran: fix passing return value to class(*) dummy argument
gcc/fortran/ChangeLog:
PR fortran/100551
* trans-expr.c (gfc_conv_procedure_call): Adjust check for
implicit conversion of actual argument to an unlimited polymorphic
procedure argument.
gcc/testsuite/ChangeLog:
PR fortran/100551
* gfortran.dg/pr100551.f90: New test.
(cherry picked from commit fe03f4fc9548b3fdbff3c8284a994feaa7d6307d)
^ permalink raw reply [flat|nested] 11+ messages in thread