From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 0B8DC3AA9839; Fri, 18 Jun 2021 14:43:47 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B8DC3AA9839
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/100630] Unexpected implicit conversion from volatile
 bool& to std::filesystem::path in gcc <= 10
Date: Fri, 18 Jun 2021 14:43:46 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 10.3.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-100630-4-0NackcCAhA@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-100630-4@http.gcc.gnu.org/bugzilla/>
References: <bug-100630-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Jun 2021 14:43:47 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100630

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:3c805829c9023da48db6d636221fd79612dff7ea

commit r9-9593-g3c805829c9023da48db6d636221fd79612dff7ea
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon May 17 11:54:06 2021 +0100

    libstdc++: Fix filesystem::path constraints for volatile [PR 100630]

    The constraint check for filesystem::path construction uses
    decltype(__is_path_src(declval<Source>())) which mean it considers
    conversion from an rvalue.  When Source is a volatile-qualified type
    it cannot use is_path_src(const Unknown&) because a const lvalue
    reference can only bind to a non-volatile rvalue.

    Since the relevant path members all have a const Source& parameter,
    the constraint should be defined in terms of declval<const Source&>(),
    not declval<Source>(). This avoids the problem of volatile-qualified
    rvalues, because we no longer use an rvalue at all.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100630
            * include/bits/fs_path.h (__is_constructible_from): Test
            construction from a const lvalue, not an rvalue.
            * include/experimental/bits/fs_path.h (__is_constructible_from):
            Likewise.
            * testsuite/27_io/filesystem/path/construct/100630.cc: New test.
            * testsuite/experimental/filesystem/path/construct/100630.cc:
            New test.

    (cherry picked from commit 4cd69a5a0dd31bc6fdef1bbabc8d6d1416014ea1)=