From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 71F6A3953C17; Tue, 18 May 2021 13:50:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 71F6A3953C17
From: "ppalka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/100631] ranges::elements_view:: _Sentinel is missing
 __distance_from() that can access _M_current of _Iterator
Date: Tue, 18 May 2021 13:50:33 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: ppalka at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-100631-4-VJ59NuhOH8@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-100631-4@http.gcc.gnu.org/bugzilla/>
References: <bug-100631-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 18 May 2021 13:50:33 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100631

--- Comment #8 from Patrick Palka <ppalka at gcc dot gnu.org> ---
(In reply to =E5=BA=B7=E6=A1=93=E7=91=8B from comment #7)
> (In reply to CVS Commits from comment #6)
> > The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org=
>:
> >=20
> > https://gcc.gnu.org/g:2e2eef80ac0c21f9533e6791ccf5e29458cbb77c
> >=20
> > commit r12-854-g2e2eef80ac0c21f9533e6791ccf5e29458cbb77c
> > Author: Patrick Palka <ppalka@redhat.com>
> > Date:   Tue May 18 00:26:07 2021 -0400
> >=20
> >     libstdc++: Fix miscellaneous issues with elements_view::_Sentinel
> > [PR100631]
> >=20=20=20=20=20
> >     libstdc++-v3/ChangeLog:
> >=20=20=20=20=20
> >             PR libstdc++/100631
> >             * include/std/ranges (elements_view::_Iterator): Also befri=
end
> >             _Sentinel<!_Const>.
> >             (elements_view::_Sentinel::_M_equal): Templatize.
> >             (elements_view::_Sentinel::_M_distance_from): Split out fro=
m ...
> >             (elements_view::_Sentinel::operator-): ... here.  Depend on
> >             _Base2 instead of _Base in the return type.
> >             * testsuite/std/ranges/adaptors/elements.cc (test06, test07=
):
> >             New tests.
>=20
>=20
>=20
> Hey, Patrick, you missed the second one:
>=20=20=20=20=20
>=20
>     template<bool _Const2,
>              typename _Base2 =3D __detail::__maybe_const_t<_Const2, _Vp>>
>     requires sized_sentinel_for<sentinel_t<_Base>, iterator_t<_Base2>>
>     friend constexpr range_difference_t<_Base2>
>     operator-(const _Iterator<_Const2>& __x, const _Sentinel& __y)
>     { return __x._M_current - __y._M_end; }
>=20
>=20
> this should be return -__y._M_distance_from(__x).

Indeed, thanks for catching that.  Fix incoming shortly..=