From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 447D33987C3F; Thu, 20 May 2021 20:49:17 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 447D33987C3F
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/100676] Redeclaring __failed_assertion() at every
 point of use of __glibcxx_assert breaks Clang CUDA
Date: Thu, 20 May 2021 20:49:17 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 11.2
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-100676-4-zernA1EHlS@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-100676-4@http.gcc.gnu.org/bugzilla/>
References: <bug-100676-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 20 May 2021 20:49:17 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100676

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:6b42b5a8a207de5e021a2916281f46bcd60b20d2

commit r12-952-g6b42b5a8a207de5e021a2916281f46bcd60b20d2
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu May 20 16:39:06 2021 +0100

    libstdc++: Use __builtin_unreachable for constexpr assertions [PR 10067=
6]

    The current implementation of compile-time precondition checks causes
    compilation to fail by calling a non-constexpr function declared at
    block scope. This breaks the CUDA compiler, which wraps some libstdc++
    headers in a pragma that declares everything as a __host__ __device__
    function, but others are not wrapped and so everything is a __host__
    function. The local declaration thus gets redeclared as two different
    types of function, which doesn't work.

    Just use __builtin_unreachable to make constant evaluation fail, instead
    of the local function declaration. Also simplify the assertion macros,
    which has the side effect of giving simpler compilation errors when
    using Clang.

    libstdc++-v3/ChangeLog:

            PR libstdc++/100676
            * include/bits/c++config (__glibcxx_assert_1): Rename to ...
            (__glibcxx_constexpr_assert): ... this.
            (__glibcxx_assert_impl): Use __glibcxx_constexpr_assert.
            (__glibcxx_assert): Define as either __glibcxx_constexpr_assert
            or __glibcxx_assert_impl.
            (__glibcxx_assert_2): Remove
            * include/debug/macros.h (_GLIBCXX_DEBUG_VERIFY_AT_F): Use
            __glibcxx_constexpr_assert instead of __glibcxx_assert_1.
            *
testsuite/21_strings/basic_string_view/element_access/char/back_constexpr_n=
eg.cc:
            Adjust expected error.
            *
testsuite/21_strings/basic_string_view/element_access/char/constexpr_neg.cc:
            Likewise.
            *
testsuite/21_strings/basic_string_view/element_access/char/front_constexpr_=
neg.cc:
            Likewise.
            Likewise.
            *
testsuite/21_strings/basic_string_view/element_access/wchar_t/back_constexp=
r_neg.cc:
            Likewise.
            *
testsuite/21_strings/basic_string_view/element_access/wchar_t/constexpr_neg=
.cc:
            Likewise.
            *
testsuite/21_strings/basic_string_view/element_access/wchar_t/front_constex=
pr_neg.cc:
            Likewise.
            * testsuite/23_containers/span/back_neg.cc: Likewise.
            * testsuite/23_containers/span/front_neg.cc: Likewise.
            * testsuite/23_containers/span/index_op_neg.cc: Likewise.=