public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "harald at gigawatt dot nl" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/100731] [11/12 Regression] GCC 11 fails to build using GCC 4.8 because of missing includes
Date: Tue, 25 May 2021 08:00:53 +0000	[thread overview]
Message-ID: <bug-100731-4-DSTniMwACx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-100731-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100731

--- Comment #6 from Harald van Dijk <harald at gigawatt dot nl> ---
(In reply to rguenther@suse.de from comment #5)
> At this point a minimal fix is prefered - in principle the file
> should be a valid source to any C++ 11 capable host compiler, not
> just GCC.  The maintainer is on leave but we do want the build to
> be fixed.  Now, since the file already includes csingal/cstring and 
> cstdarg I'd say using the C++ wrapper to C includes and qualifying
> the calls would be consistent with existing use (thus not including
> stdlib.h but cstdlib).

The minimal fix is the other one, to change the headers to <*.h>, as none of
the calls to library functions in the file are std::-qualified. :) Alright,
I'll send a patch for that once I'm able to test that the same problem is still
present on master and that the same fix is sufficient to get things working.

  parent reply	other threads:[~2021-05-25  8:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-23 15:43 [Bug bootstrap/100731] New: " harald at gigawatt dot nl
2021-05-23 15:44 ` [Bug bootstrap/100731] " harald at gigawatt dot nl
2021-05-23 15:55 ` harald at gigawatt dot nl
2021-05-25  7:26 ` [Bug c++/100731] [11/12 Regression] " rguenth at gcc dot gnu.org
2021-05-25  7:45 ` harald at gigawatt dot nl
2021-05-25  7:50 ` rguenther at suse dot de
2021-05-25  8:00 ` harald at gigawatt dot nl [this message]
2021-05-25 14:45 ` cvs-commit at gcc dot gnu.org
2021-05-25 16:27 ` harald at gigawatt dot nl
2021-05-25 17:18 ` redi at gcc dot gnu.org
2021-05-25 17:22 ` jakub at gcc dot gnu.org
2021-05-31 14:08 ` cvs-commit at gcc dot gnu.org
2021-07-09 17:26 ` [Bug c++/100731] [12 " jason at gcc dot gnu.org
2021-07-28  7:07 ` rguenth at gcc dot gnu.org
2021-12-28 12:06 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100731-4-DSTniMwACx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).