[Bug bootstrap/100734] New: /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[Bug bootstrap/100734] New: /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

            Bug ID: 100734
           Summary: /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8:
                    internal compiler error: in from_mode_char, at
                    attribs.h:304
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
  Target Milestone: ---
              Host: hppa*-*-hpux11.11
            Target: hppa*-*-hpux11.11
             Build: hppa*-*-hpux11.11

At commit a4dbd5cffa6acb100dd75017ef95dadc3d8a136f:

/test/gnu/gcc/objdir/./gcc/xgcc -B/test/gnu/gcc/objdir/./gcc/
-B/opt/gnu/gcc/gcc
-12/hppa2.0w-hp-hpux11.11/bin/ -B/opt/gnu/gcc/gcc-12/hppa2.0w-hp-hpux11.11/lib/
-isystem /opt/gnu/gcc/gcc-12/hppa2.0w-hp-hpux11.11/include -isystem
/opt/gnu/gcc
/gcc-12/hppa2.0w-hp-hpux11.11/sys-include   -fno-checking -g -O2 -O2  -g -O2
-DI
N_GCC    -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wno-format
-Wstric
t-prototypes -Wmissing-prototypes -Wold-style-definition  -isystem ./include  
-
frandom-seed=fixed-seed -fPIC -g -DIN_LIBGCC2 -fbuilding-libgcc
-fno-stack-protector   -frandom-seed=fixed-seed -fPIC -I. -I. -I../.././gcc
-I../../../gcc/libgcc -I../../../gcc/libgcc/. -I../../../gcc/libgcc/../gcc
-I../../../gcc/libgcc/../include  -DHAVE_CC_TLS -DUSE_EMUTLS -o dfi-stub.o -MT
dfi-stub.o -MD -MP -MF dfi-stub.dep -c -O2 -DL_deregister_frame_info
../../../gcc/libgcc/config/pa/stublib.c
In file included from ../../../gcc/libgcc/../gcc/tsystem.h:101,
                 from ../../../gcc/libgcc/config/pa/stublib.c:25:
/test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error:
in from_mode_char, at attribs.h:304
  291 |        extern int getopt(int, char * const [], const char *);
      |        ^~~~~~
In file included from ../../../gcc/libgcc/../gcc/tsystem.h:101,
                 from ../../../gcc/libgcc/config/pa/stublib.c:25:
/test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error:
in from_mode_char, at attribs.h:304
  291 |        extern int getopt(int, char * const [], const char *);
      |        ^~~~~~
libbacktrace could not find executable to open
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://gcc.gnu.org/bugs/> for instructions.
make[3]: *** [../../../gcc/libgcc/config/pa/t-stublib:12: dfi-stub.o] Error 1

We are hitting gcc_unreachable () in attr_access::from_mode_char (char c).

12.0.0 20210507 (experimental) (GCC) testsuite on hppa2.0w-hp-hpux11.11 build
was okay.  12.0.0 20210510 (experimental) (GCC) testsuite on
hppa64-hp-hpux11.11
was okay.

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|bootstrap                   |target
            Summary|/test/gnu/gcc/objdir/gcc/in |[12 Regression]
                   |clude-fixed/stdlib.h:291:8: |/test/gnu/gcc/objdir/gcc/in
                   |internal compiler error: in |clude-fixed/stdlib.h:291:8:
                   |from_mode_char, at          |internal compiler error: in
                   |attribs.h:304               |from_mode_char, at
                   |                            |attribs.h:304
   Target Milestone|---                         |12.0
           Keywords|                            |build, ice-on-valid-code

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---


  /* The character codes corresponding to all the access modes.  */
  static constexpr char mode_chars[5] = { '-', 'r', 'w', 'x', '^' };
Is this after building stage 1 or after building stage 2 ?

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #2 from dave.anglin at bell dot net ---
It's after stage1.  I'm bisecting.

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Possibly a dup of PR100727?

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gcc dot gnu.org

--- Comment #4 from John David Anglin <danglin at gcc dot gnu.org> ---
This ICE was introduced by the following commit:

commit eb2a917fa0779b689f09ac8d8c41b0456facbe62 (HEAD)
Author: Martin Sebor <msebor@redhat.com>
Date:   Wed May 19 16:13:13 2021 -0600

    PR c/100619 - ICE on a VLA parameter with too many dimensions

    gcc/c-family/ChangeLog:

            PR c/100619
            * c-attribs.c (build_attr_access_from_parms): Handle arbitrarily
many
            bounds.

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #5 from John David Anglin <danglin at gcc dot gnu.org> ---
Breakpoint 1, attr_access::from_mode_char (
    c=<error reading variable: Cannot access memory at address 0x0>)
    at ../../gcc/gcc/attribs.h:304
304       gcc_unreachable ();
(gdb) bt
#0  attr_access::from_mode_char (
    c=<error reading variable: Cannot access memory at address 0x0>)
    at ../../gcc/gcc/attribs.h:304
#1  0x4000000000a8311c in init_attr_rdwr_indices (rwm=0x800003fffdff14e0,
    attrs=0x800003fffdf1b9b0) at ../../gcc/gcc/attribs.c:2146
#2  0x4000000000d1e554 in warn_parm_array_mismatch (origloc=2147484671,
    fndecl=0x800003fffdf1b9b0, newparms=0x7ae4b8)
    at ../../gcc/gcc/c-family/c-warn.c:3369
#3  0x4000000000b5ebc0 in c_parser_declaration_or_fndef (
    parser=0x800003fffdff14e0, fndef_ok=128, static_assert_ok=false,
    empty_ok=true, nested=false, start_attr_ok=false,
    objc_foreach_object_declaration=0x4000000000887f48
<copy_list(tree_node*)::__FUNCTION__>, omp_declare_simd_clauses=...,
have_attrs=false,
    attrs=0x800003fffdf1d700,
    oacc_routine_data=0x4000000002f7501f <fndecl_built_in_p(tree_node
const*)+92>, fallthru_attr_p=0x800003fffdff17a0) at
../../gcc/gcc/c/c-parser.c:2342
#4  0x4000000000b5cb98 in c_parser_external_declaration (
    parser=0x800003fffdff14e0) at ../../gcc/gcc/c/c-parser.c:1777
#5  0x4000000000b5c240 in c_parser_translation_unit (parser=0x800003fffdff14e0)
    at ../../gcc/gcc/c/c-parser.c:1650
#6  0x4000000000bc644c in c_parse_file () at ../../gcc/gcc/c/c-parser.c:21994
#7  0x4000000000cafd10 in c_common_parse_file ()
    at ../../gcc/gcc/c-family/c-opts.c:1219
#8  0x40000000017db87c in compile_file () at ../../gcc/gcc/toplev.c:457
#9  0x40000000017e26e8 in do_compile () at ../../gcc/gcc/toplev.c:2203
#10 0x40000000017e2e68 in toplev::main (this=0x800003fffdff14e0,
    argc=-2147482625, argv=0x7ae4b8) at ../../gcc/gcc/toplev.c:2342
#11 0x4000000002abbee4 in main (argc=-2147482625, argv=0x800003fffdf1b9b0)
    at ../../gcc/gcc/main.c:39
(gdb) frame 1
#1  0x4000000000a8311c in init_attr_rdwr_indices (rwm=0x800003fffdff14e0,
    attrs=0x800003fffdf1b9b0) at ../../gcc/gcc/attribs.c:2146
2146              acc.mode = acc.from_mode_char (*m);
(gdb) p *m
$2 = 0 '\000'

[Bug middle-end/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-05-25
          Component|target                      |middle-end
     Ever confirmed|0                           |1

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #3)
> Possibly a dup of PR100727?

I think it is unrelated.

The problem is the fix for PR 100619, sets the attributes to be "+" but the
code in attribs.c, skip over the '+' but does not check if it is the end of the
string:
          /* Skip the internal-only plus sign.  */
          if (*m == '+')
            ++m;

          acc.str = m;
          acc.mode = acc.from_mode_char (*m);

[Bug middle-end/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #6)
> (In reply to Richard Biener from comment #3)
> > Possibly a dup of PR100727?
> 
> I think it is unrelated.
> 
> The problem is the fix for PR 100619, sets the attributes to be "+" but the
> code in attribs.c, skip over the '+' but does not check if it is the end of
> the string:

This patch might fix the ICE (sorry for the tab to spaces):
diff --git a/gcc/attribs.c b/gcc/attribs.c
index ebc0783c439..4adbe9fed5e 100644
--- a/gcc/attribs.c
+++ b/gcc/attribs.c
@@ -2140,7 +2140,10 @@ init_attr_rdwr_indices (rdwr_map *rwm, tree attrs)

          /* Skip the internal-only plus sign.  */
          if (*m == '+')
-           ++m;
+           {
+             ++m;
+             continue;
+           }

          acc.str = m;
          acc.mode = acc.from_mode_char (*m);

[Bug middle-end/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #8 from Martin Sebor <msebor at gcc dot gnu.org> ---
The plus character should always be followed by a nonempty string.  John, can
you please attach a translation unit to see if by chance I can reproduce with a
cross-compiler?  In parallel, I wonder if there's something funny about
snprintf on HP-UX.  Does the snprintf call added in r12-930 do the right thing
(i.e., append a nonempty string to spec)?

[Bug middle-end/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #9 from Martin Sebor <msebor at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #5)
> Breakpoint 1, attr_access::from_mode_char (
>     c=<error reading variable: Cannot access memory at address 0x0>)
>     at ../../gcc/gcc/attribs.h:304
> 304       gcc_unreachable ();

This error says that &c is null.  c comes from the code below:

#1  0x4000000000a8311c in init_attr_rdwr_indices (rwm=0x800003fffdff14e0,
    attrs=0x800003fffdf1b9b0) at ../../gcc/gcc/attribs.c:2146

      mode = TREE_VALUE (mode);
      if (TREE_CODE (mode) != STRING_CST)
        continue;
      gcc_assert (TREE_CODE (mode) == STRING_CST);

      for (const char *m = TREE_STRING_POINTER (mode); *m; )

Either TREE_STRING_POINTER (mode) is null or mode is set to null after one of
the calls to strtoul() later in the function.

[Bug middle-end/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #10 from dave.anglin at bell dot net ---
On 2021-05-25 3:04 p.m., msebor at gcc dot gnu.org wrote:
> In parallel, I wonder if there's something funny about
> snprintf on HP-UX.  Does the snprintf call added in r12-930 do the right thing
> (i.e., append a nonempty string to spec)?
No.  When passed a size of 0, snprintf on hpux11.11 returns 0.  This issue is
noted in Linux man page
for snprintf.

Attached a possible fix.

[Bug middle-end/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #11 from dave.anglin at bell dot net ---
On 2021-05-26 3:32 p.m., dave.anglin at bell dot net wrote:
> Attached a possible fix.
While the patch fixes boot, pr100619.c fails:

spawn /test/gnu/gcc/objdir64/gcc/xgcc -B/test/gnu/gcc/objdir64/gcc/
/test/gnu/gcc/gcc/gcc/testsuite/gcc.dg/pr100619.c -fdiagnostics-plain-output
-Wall -S -o pr100619.s
/test/gnu/gcc/gcc/gcc/testsuite/gcc.dg/pr100619.c:14:1: internal compiler
error: Segmentation fault

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|middle-end                  |target

--- Comment #12 from John David Anglin <danglin at gcc dot gnu.org> ---
Using libiberty snprintf and vsnprintf on hppa*-*-hpux* works.

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by John David Anglin <danglin@gcc.gnu.org>:

https://gcc.gnu.org/g:a0864ce8662bb9d715b51513697309f198f1da19

commit r12-1240-ga0864ce8662bb9d715b51513697309f198f1da19
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Sat Jun 5 15:48:04 2021 +0000

    Use libiberty snprintf and vsnprintf on hppa*-*-hpux*.

    libiberty/ChangeLog:

            PR target/100734
            * configure.ac: Use libiberty snprintf and vsnprintf on
            hppa*-*-hpux*.
            * configure: Regenerate.

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #14 from John David Anglin <danglin at gcc dot gnu.org> ---
Fixed.

[Bug target/100734] [12 Regression] /test/gnu/gcc/objdir/gcc/include-fixed/stdlib.h:291:8: internal compiler error: in from_mode_char, at attribs.h:304

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100734

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by John David Anglin
<danglin@gcc.gnu.org>:

https://gcc.gnu.org/g:356390c14aa70a95c15845512f2381b627cf9a96

commit r11-9051-g356390c14aa70a95c15845512f2381b627cf9a96
Author: John David Anglin <danglin@gcc.gnu.org>
Date:   Fri Oct 1 17:18:32 2021 +0000

    Use libiberty snprintf and vsnprintf on hppa*-*-hpux*.

    libiberty/ChangeLog:

            PR target/100734
            * configure.ac: Use libiberty snprintf and vsnprintf on
            hppa*-*-hpux*.
            * configure: Regenerate.