[Bug testsuite/100749] New: [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[Bug testsuite/100749] New: [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100749

            Bug ID: 100749
           Summary: [12 regression] gcc.dg/pch/valid-1.c fails after
                    r12-949
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: testsuite
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:459d84e9b6e925922246b6aff76a5202b1d4d4ba, r12-949
make  -k check-gcc RUNTESTFLAGS="pch.exp=gcc.dg/pch/valid-1.c"
FAIL: gcc.dg/pch/valid-1.c  -O0 -g -I. -Dwith_PCH  (test for warnings, line 4)
FAIL: gcc.dg/pch/valid-1.c  -O0 -g -I. -Dwith_PCH (test for excess errors)
FAIL: gcc.dg/pch/valid-1.c   -O0  -I. -Dwith_PCH  (test for warnings, line 4)
FAIL: gcc.dg/pch/valid-1.c   -O0  -I. -Dwith_PCH (test for excess errors)
FAIL: gcc.dg/pch/valid-1.c   -O1  -I. -Dwith_PCH  (test for warnings, line 4)
FAIL: gcc.dg/pch/valid-1.c   -O1  -I. -Dwith_PCH (test for excess errors)
FAIL: gcc.dg/pch/valid-1.c   -O2  -I. -Dwith_PCH  (test for warnings, line 4)
FAIL: gcc.dg/pch/valid-1.c   -O2  -I. -Dwith_PCH (test for excess errors)
FAIL: gcc.dg/pch/valid-1.c   -O3 -g  -I. -Dwith_PCH  (test for warnings, line
4)
FAIL: gcc.dg/pch/valid-1.c   -O3 -g  -I. -Dwith_PCH (test for excess errors)
FAIL: gcc.dg/pch/valid-1.c   -Os  -I. -Dwith_PCH  (test for warnings, line 4)
FAIL: gcc.dg/pch/valid-1.c   -Os  -I. -Dwith_PCH (test for excess errors)
# of expected passes            24
# of unexpected failures        12

Looks like the adjusted error message doesn't match.

commit 459d84e9b6e925922246b6aff76a5202b1d4d4ba
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Fri Apr 30 07:52:40 2021 -0700

    opts: change write_symbols to support bitmasks

        * gcc.dg/pch/valid-1.c: Adjust diagnostic message in testcase.

[Bug testsuite/100749] [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100749

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug testsuite/100749] [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[ibhagatgnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100749

--- Comment #1 from Indu Bhagat <ibhagatgnu at gmail dot com> ---
Thanks for the bug report. This is reproducible. Will look into it.

[Bug testsuite/100749] [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[ibhagatgnu at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100749

--- Comment #2 from Indu Bhagat <ibhagatgnu at gmail dot com> ---
I found the issue. I will send a fix soon, once testing on powerpc64, x86_64
finishes.

[Bug testsuite/100749] [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100749

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Indu Bhagat <ibhagat@gcc.gnu.org>:

https://gcc.gnu.org/g:a87efd32384ee78ee33d20703deaa65fba81cb2d

commit r12-1132-ga87efd32384ee78ee33d20703deaa65fba81cb2d
Author: Indu Bhagat <indu.bhagat@oracle.com>
Date:   Mon May 31 09:19:38 2021 -0700

    PR testsuite/100749 - gcc.dg/pch/valid-1.c fails after r12-949

    Fix failing pch testcases. Use xstrdup to retain a reliable copy of the
debug
    format str containing the names (df_set_names is a static string var).

    2021-05-31  Indu Bhagat  <indu.bhagat@oracle.com>

    gcc/c-family/
            PR testsuite/100749
            * c-pch.c (c_common_valid_pch): Use xstrdup for debug format set
names.

[Bug testsuite/100749] [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100749

Bill Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wschmidt at gcc dot gnu.org

--- Comment #4 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
@seurer, is this working now?  Can it be closed?

[Bug testsuite/100749] [12 regression] gcc.dg/pch/valid-1.c fails after r12-949

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100749

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from seurer at gcc dot gnu.org ---
Everything is working now.