[Bug tree-optimization/100774] New: [12 Regression] -fcompare-debug failure (length) with -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace

[Bug tree-optimization/100774] New: [12 Regression] -fcompare-debug failure (length) with -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100774

            Bug ID: 100774
           Summary: [12 Regression] -fcompare-debug failure (length) with
                    -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
                CC: aoliva at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu

Created attachment 50872
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50872&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-g++ -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace
-fcompare-debug testcase.C
x86_64-pc-linux-gnu-g++: error: testcase.C: '-fcompare-debug' failure (length)
$ diff -u *gkd
--- a-testcase.C.gkd    2021-05-26 17:07:09.776753885 +0200
+++ a-testcase.gk.C.gkd 2021-05-26 17:07:09.856753886 +0200
@@ -1,31 +1,15 @@

-Declarations used by foo, sorted by DECL_UID:
-0:   extern void error (void);

 ;; Function foo (_Z3foov, funcdef_no=1, cgraph_uid=2, symbol_order=2)
(executed once)

 (note # 0 0 NOTE_INSN_DELETED)
-(note # 0 0 [bb 2] NOTE_INSN_BASIC_BLOCK)
 (note # 0 0 NOTE_INSN_FUNCTION_BEG)
-(insn/f:TI # 0 0 2 (parallel [
-            (set (reg/f:DI 7 sp)
-                (plus:DI (reg/f:DI 7 sp)
-                    (const_int -8 [0xfffffffffffffff8])))
-            (clobber (reg:CC 17 flags))
-            (clobber (mem:BLK (scratch) [  A8]))
-        ]) "testcase.C":12:1# {pro_epilogue_adjust_stack_add_di}
-     (expr_list:REG_UNUSED (reg:CC 17 flags)
-        (expr_list:REG_CFA_ADJUST_CFA (set (reg/f:DI 7 sp)
-                (plus:DI (reg/f:DI 7 sp)
-                    (const_int -8 [0xfffffffffffffff8])))
-            (nil))))
 (note # 0 0 NOTE_INSN_PROLOGUE_END)
-(call_insn:TI # 0 0 2 (call (mem:QI (symbol_ref:DI ("_Z5errorv") [flags 0x41] 
<function_decl # error>) [ error S1 A8])
-        (const_int 0 [0])) "testcase.C":19:12# {*call}
-     (expr_list:REG_CALL_DECL (symbol_ref:DI ("_Z5errorv") [flags 0x41] 
<function_decl # error>)
-        (expr_list:REG_ARGS_SIZE (const_int 0 [0])
-            (expr_list:REG_NORETURN (const_int 0 [0])
-                (nil))))
-    (nil))
+(code_label # 0 0 2 2 (nil) [1 uses])
+(note # 0 0 [bb 2] NOTE_INSN_BASIC_BLOCK)
+(jump_insn:TI # 0 0 2 (set (pc)
+        (label_ref #))# {jump}
+     (nil)
+ -> 2)
 (barrier # 0 0)
 (note # 0 0 NOTE_INSN_DELETED)

[Bug tree-optimization/100774] [12 Regression] -fcompare-debug failure (length) with -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100774

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |amacleod at redhat dot com,
                   |                            |jakub at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
           Priority|P3                          |P1
   Last reconfirmed|                            |2021-05-26
   Target Milestone|---                         |12.0

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r12-852-g3f476de7fd274f619a0b04c2e2f7077ee8ab17a5

[Bug tree-optimization/100774] [12 Regression] -fcompare-debug failure (length) with -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100774

--- Comment #2 from Andrew Macleod <amacleod at redhat dot com> ---
I have a fix for this... 
Do we add -fcompare-debug tests into the testsuite?  I don't see any other
tests with it.

[Bug tree-optimization/100774] [12 Regression] -fcompare-debug failure (length) with -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100774

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Andrew Macleod from comment #2)
> I have a fix for this... 
> Do we add -fcompare-debug tests into the testsuite?  I don't see any other
> tests with it.

Sure we do, grep will show quite some.

[Bug tree-optimization/100774] [12 Regression] -fcompare-debug failure (length) with -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100774

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:1ffbfc2659e7e8fa5c5d633869870af8fca5e8ee

commit r12-1134-g1ffbfc2659e7e8fa5c5d633869870af8fca5e8ee
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Thu May 27 11:19:10 2021 -0400

    Range invariant global values are also always current.

    when a range evolves to the point where it becomes a constant, it is
    marked as invariant.  Rather than marking it as always_current in the
    timestamp, give it the correct timestamp and just never flag it as stale.
    This will allow other names which use this value to become stale and be
    recomputed using the newly invariant value.

            gcc/
            PR tree-optimization/100774
            * gimple-range-cache.cc (ranger_cache::get_non_stale_global_range):
            Constant values are also not stale.
            (ranger_cache::set_global_range): Range invariant values should
also
            have the correct timestamp.

            gcc/testsuite
            PR tree-optimization/100774
            * g++.dg/pr100774.C: New.

[Bug tree-optimization/100774] [12 Regression] -fcompare-debug failure (length) with -O2 -fno-tree-forwprop --param=evrp-mode=ranger-trace

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100774

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Andrew Macleod <amacleod at redhat dot com> ---
fixed.