[Bug target/100777] New: MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[Bug target/100777] New: MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

            Bug ID: 100777
           Summary: MMA builtin usage ICEs when used in a #pragma omp
                    parallel and using -fopenmp
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: bergner at gcc dot gnu.org
  Target Milestone: ---

bergner@pike:~/$ cat bug.i 
void
foo (__vector_quad *dst)
{
#pragma omp parallel
  {
    __builtin_mma_xxsetaccz (dst);
  }
}

bergner@pike:~/$ gcc -S -O1 -mcpu=power10 -fopenmp bug.i 
during GIMPLE pass: ssa
bug.i: In function ‘foo’:
bug.i:8:1: internal compiler error: Segmentation fault
    8 | }
      | ^
0x10b89f63 crash_signal
        /home/bergner/gcc/gcc-fsf-mainline-base/gcc/toplev.c:327
0x10ea5a00 verify_ssa(bool, bool)
        /home/bergner/gcc/gcc-fsf-mainline-base/gcc/tree-ssa.c:1070
...

This fails on trunk back to GCC10 (ie, first MMA support).

[Bug target/100777] MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-05-26
             Target|                            |powerpc64le-linux
      Known to fail|                            |10.0, 11.0, 12.0

--- Comment #1 from Peter Bergner <bergner at gcc dot gnu.org> ---
Mine.

I have a patch I'm testing that changes the MMA gimple builtin expansion code
to use create_tmp_reg_or_ssa_name() rather than make_ssa_name() that seems to
fix the ICE.

[Bug target/100777] MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2021-May/571
                   |                            |339.html
   Target Milestone|---                         |12.0
           Assignee|unassigned at gcc dot gnu.org      |bergner at gcc dot gnu.org

[Bug target/100777] MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Peter Bergner <bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:20073534c0ccca0a4e079c053ee0874af10b2ea0

commit r12-1439-g20073534c0ccca0a4e079c053ee0874af10b2ea0
Author: Peter Bergner <bergner@linux.ibm.com>
Date:   Mon Jun 14 16:55:18 2021 -0500

    rs6000: MMA builtin usage ICEs when used in a #pragma omp parallel and
using -fopenmp [PR100777]

    Using an MMA builtin within an openmp parallel code block, leads to an SSA
    verification ICE on the temporaries we create while expanding the MMA
builtins
    at gimple time.  The solution is to use create_tmp_reg_or_ssa_name(), which
    knows when to create either an SSA or register temporary.

    2021-06-14  Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/100777
            * config/rs6000/rs6000-call.c (rs6000_gimple_fold_mma_builtin): Use
            create_tmp_reg_or_ssa_name().

    gcc/testsuite/
            PR target/100777
            * gcc.target/powerpc/pr100777.c: New test.

[Bug target/100777] MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

--- Comment #3 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed on trunk.  I'll backport the fix to gcc11 and gcc10 after baking on trunk
for a day or two.

[Bug target/100777] MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:04a6793eec7f3482f3fb1273a725b3001865a685

commit r11-8610-g04a6793eec7f3482f3fb1273a725b3001865a685
Author: Peter Bergner <bergner@linux.ibm.com>
Date:   Mon Jun 14 16:55:18 2021 -0500

    rs6000: MMA builtin usage ICEs when used in a #pragma omp parallel and
using -fopenmp [PR100777]

    Using an MMA builtin within an openmp parallel code block, leads to an SSA
    verification ICE on the temporaries we create while expanding the MMA
builtins
    at gimple time.  The solution is to use create_tmp_reg_or_ssa_name(), which
    knows when to create either an SSA or register temporary.

    2021-06-14  Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/100777
            * config/rs6000/rs6000-call.c (rs6000_gimple_fold_mma_builtin): Use
            create_tmp_reg_or_ssa_name().

    gcc/testsuite/
            PR target/100777
            * gcc.target/powerpc/pr100777.c: New test.

    (cherry picked from commit 20073534c0ccca0a4e079c053ee0874af10b2ea0)

[Bug target/100777] MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:

https://gcc.gnu.org/g:9e10782370391ed48d2a690a4205594f6b7d2fbe

commit r10-9931-g9e10782370391ed48d2a690a4205594f6b7d2fbe
Author: Peter Bergner <bergner@linux.ibm.com>
Date:   Mon Jun 14 16:55:18 2021 -0500

    rs6000: MMA builtin usage ICEs when used in a #pragma omp parallel and
using -fopenmp [PR100777]

    Using an MMA builtin within an openmp parallel code block, leads to an SSA
    verification ICE on the temporaries we create while expanding the MMA
builtins
    at gimple time.  The solution is to use create_tmp_reg_or_ssa_name(), which
    knows when to create either an SSA or register temporary.

    2021-06-14  Peter Bergner  <bergner@linux.ibm.com>

    gcc/
            PR target/100777
            * config/rs6000/rs6000-call.c (rs6000_gimple_fold_mma_builtin): Use
            create_tmp_reg_or_ssa_name().

    gcc/testsuite/
            PR target/100777
            * gcc.target/powerpc/pr100777.c: New test.

    (cherry picked from commit 20073534c0ccca0a4e079c053ee0874af10b2ea0)

[Bug target/100777] MMA builtin usage ICEs when used in a #pragma omp parallel and using -fopenmp

[bergner at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100777

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed everywhere.