public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/100823] Special member functions of common_iterator should be conditionally trivial Date: Thu, 27 Apr 2023 23:04:14 +0000 [thread overview] Message-ID: <bug-100823-4-bi8HjUV5vJ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-100823-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100823 --- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-10 branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:5d7de4c8fd9af68011e1fa7bc1d022db81d89594 commit r10-11317-g5d7de4c8fd9af68011e1fa7bc1d022db81d89594 Author: Jonathan Wakely <jwakely@redhat.com> Date: Wed Jul 20 16:51:44 2022 +0100 libstdc++: Fix std::common_iterator assignment [PR100823] This fixes the following conformance problems reported in the PR: - Move constructor and move assignment should be defined. - Copy assignment from a valueless object should be allowed. Assignment is completely rewritten by this patch, as the previous version had a number of problems. The converting assignment failed to handle the case of assigning a new value to a valueless object, which should work. It only accepted lvalue arguments, so wasn't usable to implement the move assignment operator. Finally, it enforced the precondition that the argument is not valueless, which is correct for the converting assignment but not for the copy assignment. A new _M_assign member is added to handle all cases of assignment (copying from an lvalue, moving from an rvalue, and converting from a different type). The not valueless precondition is checked in the converting assignment before calling _M_assign, so isn't enforced for copy and move assignment. The new function no longer uses a switch, so handles valueless objects as the LHS or RHS of the assignment. libstdc++-v3/ChangeLog: PR libstdc++/100823 * include/bits/stl_iterator.h (common_iterator): Define move constructor and move assignment operator. (common_iterator::_M_assign): New function implementing assignment. (common_iterator::operator=): Use _M_assign. (common_iterator::_S_valueless): New constant. * testsuite/24_iterators/common_iterator/100823.cc: New test. (cherry picked from commit 56c999860bbbb2fd5091ba0985e2e5eaa90c6478)
next prev parent reply other threads:[~2023-04-27 23:04 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-29 5:47 [Bug libstdc++/100823] New: " rs2740 at gmail dot com 2021-06-17 12:30 ` [Bug libstdc++/100823] " redi at gcc dot gnu.org 2021-06-29 19:14 ` redi at gcc dot gnu.org 2022-07-20 22:59 ` cvs-commit at gcc dot gnu.org 2022-07-20 22:59 ` cvs-commit at gcc dot gnu.org 2022-07-20 23:01 ` redi at gcc dot gnu.org 2022-07-21 11:17 ` cvs-commit at gcc dot gnu.org 2022-07-22 7:08 ` cvs-commit at gcc dot gnu.org 2022-07-22 7:10 ` redi at gcc dot gnu.org 2023-04-27 23:04 ` cvs-commit at gcc dot gnu.org [this message] 2023-04-27 23:06 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100823-4-bi8HjUV5vJ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).