[Bug c++/100859] New: ICE in tsubst_omp_clauses, at cp/pt.c:17520

[Bug c++/100859] New: ICE in tsubst_omp_clauses, at cp/pt.c:17520

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

            Bug ID: 100859
           Summary: ICE in tsubst_omp_clauses, at cp/pt.c:17520
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: openmp
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

g++-12.0.0-alpha20210530 snapshot (g:a0a7adeea31918deefb053a9a15257af94aecfaf)
ICEs when compiling the following testcase, reduced from
test/OpenMP/task_ast_print.cpp from the clang 12.0.0 test suite, w/ -fopenmp:

struct S1 {
  S1 () {}
};

template <typename T>
class S7 {
protected:
  T c[10];

public:
  S7 () {
#pragma omp task affinity (iterator (i = 0 : 10 : 1): c[i])
    for (int k = 0; k < 1; ++k)
      ;
  }
};

struct S8 : public S7<S1> {
  S8 () : S7<S1> () {}
};

% g++-12.0.0 -fopenmp -c jhbrjcts.cpp
jhbrjcts.cpp: In instantiation of 'S7<T>::S7() [with T = S1]':
jhbrjcts.cpp:19:19:   required from here
jhbrjcts.cpp:12:9: internal compiler error: in tsubst_omp_clauses, at
cp/pt.c:17520
   12 | #pragma omp task affinity (iterator (i = 0 : 10 : 1): c[i])
      |         ^~~
0x6b8a81 tsubst_omp_clauses
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:17520
0xab7392 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:18720
0xab726e tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:18507
0xab7eb2 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:18142
0xab7eb2 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:18156
0xab726e tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:18507
0xabd308 tsubst_expr(tree_node*, tree_node*, int, tree_node*, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:18142
0xabd308 instantiate_body
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:25843
0xabe502 instantiate_decl(tree_node*, bool, bool)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:26137
0xae36ab instantiate_pending_templates(int)
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/pt.c:26216
0x9a4d7b c_parse_final_cleanups()
       
/var/tmp/portage/sys-devel/gcc-12.0.0_alpha20210530/work/gcc-12-20210530/gcc/cp/decl2.c:4966

[Bug c++/100859] [12 Regression] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICE in tsubst_omp_clauses,  |[12 Regression] ICE in
                   |at cp/pt.c:17520            |tsubst_omp_clauses, at
                   |                            |cp/pt.c:17520 since
                   |                            |r12-1108-g9a5de4d5af1c10a8
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-06-02
                 CC|                            |burnus at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-1108-g9a5de4d5af1c10a8.

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
            Summary|[12 Regression] ICE in      |[12 Regression][OpenMP] ICE
                   |tsubst_omp_clauses, at      |in tsubst_omp_clauses, at
                   |cp/pt.c:17520 since         |cp/pt.c:17520 since
                   |r12-1108-g9a5de4d5af1c10a8  |r12-1108-g9a5de4d5af1c10a8

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #1)
> Started with r12-1108-g9a5de4d5af1c10a8.
... unsurprisingly – as the 'affinity' clause wasn't supported before.


Using 'depend' instead of 'affinity' fails with:

dep.cc:12:58: error: ‘S7<S1>::c’ is not a variable in ‘depend’ clause
   12 | #pragma omp task depend (iterator (i = 0 : 10 : 1), out: c[i])

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
WIP testcase:
struct S {
  S () {}
};

struct W {
  S c[10];
  W () {
#pragma omp task affinity (iterator (i = 0 : 10 : 1): c[i])
    ;
#pragma omp task depend (iterator (i = 0 : 10 : 1), inout: c[i])
    ;
#pragma omp task affinity (this[0])
    ;
#pragma omp task depend (inout: this[0])
    ;
#pragma omp taskwait
  }
};

template <typename T>
struct U {
  T c[10];
  U () {
#pragma omp task affinity (iterator (i = 0 : 10 : 1): c[i])
    ;
#pragma omp task depend (iterator (i = 0 : 10 : 1), inout: c[i])
    ;
#pragma omp task affinity (this[0])
    ;
#pragma omp task depend (inout: this[0])
    ;
#pragma omp taskwait
  }
};

struct V : public U<S> {
  V () : U<S> () {}
};

W w;
V v;

and WIP patch:
--- gcc/cp/semantics.c.jj       2021-06-02 10:07:47.633826543 +0200
+++ gcc/cp/semantics.c  2021-06-02 11:35:39.490212873 +0200
@@ -4968,7 +4968,11 @@ handle_omp_array_sections_1 (tree c, tre
          if (REFERENCE_REF_P (t))
            t = TREE_OPERAND (t, 0);
        }
-      if (!VAR_P (t) && TREE_CODE (t) != PARM_DECL)
+      if (TREE_CODE (t) == FIELD_DECL
+         && (OMP_CLAUSE_CODE (c) == OMP_CLAUSE_AFFINITY
+             || OMP_CLAUSE_CODE (c) == OMP_CLAUSE_DEPEND))
+       ret = finish_non_static_data_member (t, NULL_TREE, NULL_TREE);
+      else if (!VAR_P (t) && TREE_CODE (t) != PARM_DECL)
        {
          if (processing_template_decl && TREE_CODE (t) != OVERLOAD)
            return NULL_TREE;
@@ -4985,7 +4989,9 @@ handle_omp_array_sections_1 (tree c, tre
       else if (ort == C_ORT_OMP
               && TREE_CODE (t) == PARM_DECL
               && DECL_ARTIFICIAL (t)
-              && DECL_NAME (t) == this_identifier)
+              && DECL_NAME (t) == this_identifier
+              && OMP_CLAUSE_CODE (c) != OMP_CLAUSE_AFFINITY
+              && OMP_CLAUSE_CODE (c) != OMP_CLAUSE_DEPEND)
        {
          error_at (OMP_CLAUSE_LOCATION (c),
                    "%<this%> allowed in OpenMP only in %<declare simd%>"
@@ -7468,7 +7474,6 @@ finish_omp_clauses (tree clauses, enum c
            }
          goto handle_field_decl;

-       case OMP_CLAUSE_AFFINITY:
        case OMP_CLAUSE_DEPEND:
          t = OMP_CLAUSE_DECL (c);
          if (t == NULL_TREE)
@@ -7477,13 +7482,15 @@ finish_omp_clauses (tree clauses, enum c
                          == OMP_CLAUSE_DEPEND_SOURCE);
              break;
            }
-         if (OMP_CLAUSE_CODE (c) == OMP_CLAUSE_DEPEND
-             && OMP_CLAUSE_DEPEND_KIND (c) == OMP_CLAUSE_DEPEND_SINK)
+         if (OMP_CLAUSE_DEPEND_KIND (c) == OMP_CLAUSE_DEPEND_SINK)
            {
              if (cp_finish_omp_clause_depend_sink (c))
                remove = true;
              break;
            }
+         /* FALLTHRU */
+       case OMP_CLAUSE_AFFINITY:
+         t = OMP_CLAUSE_DECL (c);
          if (TREE_CODE (t) == TREE_LIST
              && TREE_PURPOSE (t)
              && TREE_CODE (TREE_PURPOSE (t)) == TREE_VEC)
@@ -7543,11 +7550,9 @@ finish_omp_clauses (tree clauses, enum c
                   && TREE_CODE (TREE_OPERAND (t, 1)) == FIELD_DECL
                   && DECL_BIT_FIELD (TREE_OPERAND (t, 1)))
            {
-             gcc_assert (OMP_CLAUSE_CODE (c) == OMP_CLAUSE_DEPEND
-                         || OMP_CLAUSE_CODE (c) == OMP_CLAUSE_AFFINITY);
              error_at (OMP_CLAUSE_LOCATION (c),
                        "bit-field %qE in %qs clause", t,
-                         omp_clause_code_name[OMP_CLAUSE_CODE (c)]);
+                       omp_clause_code_name[OMP_CLAUSE_CODE (c)]);
              remove = true;
            }
          else if (OMP_CLAUSE_CODE (c) == OMP_CLAUSE_DEPEND
--- gcc/cp/pt.c.jj      2021-05-31 10:11:15.149978907 +0200
+++ gcc/cp/pt.c 2021-06-02 10:41:31.319178655 +0200
@@ -17399,6 +17399,7 @@ tsubst_omp_clauses (tree clauses, enum c
        case OMP_CLAUSE_COPYPRIVATE:
        case OMP_CLAUSE_UNIFORM:
        case OMP_CLAUSE_DEPEND:
+       case OMP_CLAUSE_AFFINITY:
        case OMP_CLAUSE_FROM:
        case OMP_CLAUSE_TO:
        case OMP_CLAUSE_MAP:

There are still ICEs on it though (on the non-template case).

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
That last ICE seems to be specific to cdtors only, so iterator handling during
cdtor cloning...

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 50908
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=50908&action=edit
gcc12-pr100859.patch

Full untested patch.

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:098f4e989beb1a1be1157430c56ea4f158c1d538

commit r12-1171-g098f4e989beb1a1be1157430c56ea4f158c1d538
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Jun 3 10:38:08 2021 +0200

    openmp: Assorted depend/affinity/iterator related fixes [PR100859]

    The depend-iterator-3.C testcases shows various bugs.

    1) tsubst_omp_clauses didn't handle OMP_CLAUSE_AFFINITY (should be
       handled like OMP_CLAUSE_DEPEND)
    2) because locators can be arbitrary lvalue expressions, we need
       to allow for C++ array section base (especially when array section
       is just an array reference) FIELD_DECLs, handle them as this->member,
       but don't need to privatize in any way
    3) similarly for this as base
    4) depend(inout: this) is invalid, but for different reason than the
reported
       one, again this is an expression, but not lvalue expression, so that
       should be reported
    5) the ctor/dtor cloning in the C++ FE (which is using walk_tree with
       copy_tree_body_r) didn't handle iterators correctly, walk_tree normally
       doesn't walk TREE_PURPOSE of TREE_LIST, and in the iterator case
       that TREE_VEC contains also a BLOCK that needs special handling during
       copy_tree_body_r

    2021-06-03  Jakub Jelinek  <jakub@redhat.com>

            PR c++/100859
    gcc/
            * tree-inline.c (copy_tree_body_r): Handle iterators on
            OMP_CLAUSE_AFFINITY or OMP_CLAUSE_DEPEND.
    gcc/c/
            * c-typeck.c (c_finish_omp_clauses): Move OMP_CLAUSE_AFFINITY
            after depend only cases.
    gcc/cp/
            * semantics.c (handle_omp_array_sections_1): For
            OMP_CLAUSE_{AFFINITY,DEPEND} handle FIELD_DECL base using
            finish_non_static_data_member and allow this as base.
            (finish_omp_clauses): Move OMP_CLAUSE_AFFINITY
            after depend only cases.  Let this be diagnosed by !lvalue_p
            case for OMP_CLAUSE_{AFFINITY,DEPEND} and remove useless
            assert.
            * pt.c (tsubst_omp_clauses): Handle OMP_CLAUSE_AFFINITY.
    gcc/testsuite/
            * g++.dg/gomp/depend-iterator-3.C: New test.
            * g++.dg/gomp/this-1.C: Don't expect any diagnostics for
            this as base expression of depend array section, expect a different
            error wording for this as depend locator and add testcases
            for affinity clauses.

[Bug c++/100859] [12 Regression][OpenMP] ICE in tsubst_omp_clauses, at cp/pt.c:17520 since r12-1108-g9a5de4d5af1c10a8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100859

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.