public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/100874] New: [12 Regression] slight missed optimization with min<a,CST>-CST on aarch64
Date: Wed, 02 Jun 2021 09:32:35 +0000	[thread overview]
Message-ID: <bug-100874-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100874

            Bug ID: 100874
           Summary: [12 Regression] slight missed optimization with
                    min<a,CST>-CST on aarch64
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64-*-*

Take:
int f(int a) { return a < 4 ? a - 4 : 0; }
int f1(int a) { int x = a - 4; if (a < 4) return x; return 0; }
int f2(int a) { int t = a < 4 ? a : 4; return t - 4; }

In GCC 11, we produce:
f(int):
        mov     w1, 4
        cmp     w0, w1
        csel    w0, w0, w1, le
        sub     w0, w0, #4
        ret
f1(int):
        subs    w0, w0, 4
        csel    w0, w0, wzr, lt
        ret
f2(int):
        mov     w1, 4
        cmp     w0, w1
        csel    w0, w0, w1, le
        sub     w0, w0, #4
        ret

On the trunk all three give the same code gen (due to PHI-OPT being improved)
but of what f and f2 used to give.
All three should produce what f1 had produed instead.
This is gcc.target/aarch64/subs_compare_2.c

             reply	other threads:[~2021-06-02  9:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-02  9:32 pinskia at gcc dot gnu.org [this message]
2021-06-02  9:33 ` [Bug target/100874] " pinskia at gcc dot gnu.org
2021-06-02  9:35 ` pinskia at gcc dot gnu.org
2021-06-02  9:39 ` pinskia at gcc dot gnu.org
2022-02-15 18:10 ` [Bug target/100874] [12 Regression] slight missed optimization with min<a,CST>-CST on aarch64 (subs_compare_2.c) cvs-commit at gcc dot gnu.org
2022-02-15 18:15 ` rsandifo at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-100874-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).