From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 1CA04399E057; Fri,  4 Jun 2021 18:50:33 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1CA04399E057
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug d/100882] ICE in gimplify_var_or_parm_decl, at gimplify.c:2755
Date: Fri, 04 Jun 2021 18:50:33 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: d
X-Bugzilla-Version: 9.4.1
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ibuclaw at gdcproject dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-100882-4-Wx94AZqJI0@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-100882-4@http.gcc.gnu.org/bugzilla/>
References: <bug-100882-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2021 18:50:33 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100882

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Iain Buclaw
<ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:dcc5cf980af747941b32fd16c1d6a07177a1a404

commit r10-9891-gdcc5cf980af747941b32fd16c1d6a07177a1a404
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Fri Jun 4 19:38:26 2021 +0200

    d: Fix ICE in gimplify_var_or_parm_decl, at gimplify.c:2755 (PR100882)

    Constructor calls for temporaries were reusing the TARGET_EXPR_SLOT of a
    TARGET_EXPR for an assignment, which later got passed to `build_assign',
    which stripped away the outer TARGET_EXPR, leaving a reference to a lone
    temporary with no declaration.

    This stripping away of the TARGET_EXPR also discarded any cleanups that
    may have been assigned to the expression as well.

    So now the reuse of TARGET_EXPR_SLOT has been removed, and
    `build_assign' now constructs assignments inside the TARGET_EXPR_INITIAL
    slot.  This has also been extended to `return_expr', to deal with
    possibility of a TARGET_EXPR being returned.

    gcc/d/ChangeLog:

            PR d/100882
            * d-codegen.cc (build_assign): Construct initializations inside
            TARGET_EXPR_INITIAL.
            (compound_expr): Remove intermediate expressions that have no
            side-effects.
            (return_expr): Construct returns inside TARGET_EXPR_INITIAL.
            * expr.cc (ExprVisitor::visit (CallExp *)): Remove useless
assignment
            to TARGET_EXPR_SLOT.

    gcc/testsuite/ChangeLog:

            PR d/100882
            * gdc.dg/pr100882a.d: New test.
            * gdc.dg/pr100882b.d: New test.
            * gdc.dg/pr100882c.d: New test.
            * gdc.dg/pr100882d.d: New test.

    (cherry picked from commit e8761d4c21b5f4cc1c5612be9bf952a07c8a2238)=