public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug d/100882] ICE in gimplify_var_or_parm_decl, at gimplify.c:2755 Date: Fri, 04 Jun 2021 18:51:54 +0000 [thread overview] Message-ID: <bug-100882-4-buu3sNuHna@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-100882-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100882 --- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-9 branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>: https://gcc.gnu.org/g:b81bb0a6025588ac752cd78cce74ecf0d9ab4494 commit r9-9569-gb81bb0a6025588ac752cd78cce74ecf0d9ab4494 Author: Iain Buclaw <ibuclaw@gdcproject.org> Date: Fri Jun 4 19:38:26 2021 +0200 d: Fix ICE in gimplify_var_or_parm_decl, at gimplify.c:2755 (PR100882) Constructor calls for temporaries were reusing the TARGET_EXPR_SLOT of a TARGET_EXPR for an assignment, which later got passed to `build_assign', which stripped away the outer TARGET_EXPR, leaving a reference to a lone temporary with no declaration. This stripping away of the TARGET_EXPR also discarded any cleanups that may have been assigned to the expression as well. So now the reuse of TARGET_EXPR_SLOT has been removed, and `build_assign' now constructs assignments inside the TARGET_EXPR_INITIAL slot. This has also been extended to `return_expr', to deal with possibility of a TARGET_EXPR being returned. gcc/d/ChangeLog: PR d/100882 * d-codegen.cc (build_assign): Construct initializations inside TARGET_EXPR_INITIAL. (compound_expr): Remove intermediate expressions that have no side-effects. (return_expr): Construct returns inside TARGET_EXPR_INITIAL. * expr.cc (ExprVisitor::visit (CallExp *)): Remove useless assignment to TARGET_EXPR_SLOT. gcc/testsuite/ChangeLog: PR d/100882 * gdc.dg/pr100882a.d: New test. * gdc.dg/pr100882b.d: New test. * gdc.dg/pr100882c.d: New test. * gdc.dg/pr100882d.d: New test. (cherry picked from commit e8761d4c21b5f4cc1c5612be9bf952a07c8a2238)
next prev parent reply other threads:[~2021-06-04 18:51 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-02 18:57 [Bug d/100882] New: " ibuclaw at gdcproject dot org 2021-06-04 18:49 ` [Bug d/100882] " cvs-commit at gcc dot gnu.org 2021-06-04 18:50 ` cvs-commit at gcc dot gnu.org 2021-06-04 18:50 ` cvs-commit at gcc dot gnu.org 2021-06-04 18:51 ` cvs-commit at gcc dot gnu.org [this message] 2021-06-04 18:52 ` ibuclaw at gdcproject dot org 2021-09-17 6:46 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100882-4-buu3sNuHna@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).