From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 7759D3886C7A; Mon,  7 Jun 2021 16:06:38 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7759D3886C7A
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/100918] [9/10/11/12 Regression] Naming a destructor as a
 qualified template-id results in bogus access error
Date: Mon, 07 Jun 2021 16:06:38 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.0
X-Bugzilla-Keywords: rejects-valid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: ppalka at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 9.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-100918-4-0sCFxVb7Ki@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-100918-4@http.gcc.gnu.org/bugzilla/>
References: <bug-100918-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jun 2021 16:06:38 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100918

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:

https://gcc.gnu.org/g:6cb35b606c39d5f21f3298c77bfbcaaef3fbc872

commit r12-1263-g6cb35b606c39d5f21f3298c77bfbcaaef3fbc872
Author: Patrick Palka <ppalka@redhat.com>
Date:   Mon Jun 7 12:02:08 2021 -0400

    c++: access of dtor named by qualified template-id [PR100918]

    Here, when resolving the destructor named by Inner<int>::~Inner<int>
    (which is valid until C++20) we end up in cp_parser_lookup_name called
    indirectly from cp_parser_template_id to look up the name Inner from
    the scope Inner<int>.  The lookup naturally finds the injected-class-na=
me,
    and because the flag is_template is true, we adjust this lookup result
    to the TEMPLATE_DECL Inner.  We then check access of this adjusted
    lookup result.  But this access check fails because the lookup scope is
    Inner<int> and the context_for_name_lookup for the TEMPLATE_DECL is
    Outer (whereas for the injected-class-name it's also Inner<int>).

    The simplest fix seems to be to check access of the original lookup
    result (the injected-class-name) instead of the adjusted result (the
    TEMPLATE_DECL).  So this patch moves the access check in
    cp_parser_lookup_name to before the injected-class-name adjustment.

            PR c++/100918

    gcc/cp/ChangeLog:

            * parser.c (cp_parser_lookup_name): Check access of the lookup
            result before we potentially adjust an injected-class-name to
            its TEMPLATE_DECL.

    gcc/testsuite/ChangeLog:

            * g++.dg/template/access38.C: New test.=