From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id C28F93858D28; Sun, 9 Apr 2023 17:21:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C28F93858D28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1681060919; bh=KLBnn0HL4lFR6YDUDgBZ2Db7rF7RI4yOnpktXDLLNoc=; h=From:To:Subject:Date:In-Reply-To:References:From; b=rd4wS7kp+9fm1UoP/GXQVCWzl/r5GFrZHQAxIl/mIhHEmFBkWbjo6oLWla1x3tEQe BoncIP3NMSu4kOGGf7WSzMzlk3SVdB4Q7stPn/wjWDOvxyRb/k56blnBklwTD0sKsx 8IhCkKOkNMU+UWnzOipIm+GvQiMFPpC3O4wCfFZI= From: "pinskia at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/100958] two_value_replacement should move to match.pd Date: Sun, 09 Apr 2023 17:21:58 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: enhancement X-Bugzilla-Who: pinskia at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D100958 --- Comment #1 from Andrew Pinski --- Here is the start of the conversion to match.pd, there must be an easier wa= y to see the range too: #if GIMPLE /* Optimize x in range [cst1, cst2] where cst2 =3D cst1 + 1 (x op CSTN) ? CST3 : CST4 # where op is =3D=3D or !=3D and N is 1 or 2 # where cst3 =3D=3D cst4 + 1 or cst4 =3D=3D cst3 + 1 to x + (min (cst3, cst4) - cst1) or (min (cst3, cst4) + cst1) - x depending on op, N and which of cst3 and cst4 is smaller. */ (for eqne (eq ne) (simplify (cond (eqne @0 INTEGER_CST@1) INTEGER_CST@2 INTEGER_CST@3) (if (tree_int_cst_lt (@2, @3) ? wi::to_widest (@2) + 1 !=3D wi::to_widest (@3) : wi::to_widest (@3) + 1 !=3D wi::to_widest (@2)) (with { wide_int min, max; value_range r; get_range_query (cfun)->range_of_expr (r, lhs); if (r.kind () =3D=3D VR_RANGE) { min =3D r.lower_bound (); max =3D r.upper_bound (); } else { int prec =3D TYPE_PRECISION (TREE_TYPE (lhs)); signop sgn =3D TYPE_SIGN (TREE_TYPE (lhs)); min =3D wi::min_value (prec, sgn); max =3D wi::max_value (prec, sgn); } } (if (min + 1 =3D=3D max && (wi::to_wide (@1) =3D=3D min || wi::to_wide (@1) =3D=3D max)) #endif=