public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/100977] [C++23] Implement C++ Identifier Syntax using Unicode Standard Annex 31 Date: Thu, 05 Aug 2021 15:34:53 +0000 [thread overview] Message-ID: <bug-100977-4-x2HeAlvz52@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-100977-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100977 --- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:4805b92a32637b987f924463d6af9dcf95b21f63 commit r12-2771-g4805b92a32637b987f924463d6af9dcf95b21f63 Author: Jakub Jelinek <jakub@redhat.com> Date: Thu Aug 5 17:34:16 2021 +0200 libcpp: Fix makeucnid bug with combining values [PR100977] I've noticed in ucnid.h two adjacent lines that had all flags and combine values identical and as such were supposed to be merged. This is due to a bug in makeucnid.c, which records last_flag, last_combine and really_safe of what has just been printed, but because of a typo mishandles it for last_combine, always compares against the combining_value[0] which is 0. This has two effects on the table, one is that often the table is unnecessarily large, as for non-zero .combine every character has its own record instead of adjacent characters with the same flags and combine being merged. This means larger tables. The other is that sometimes the last char that has combine set doesn't actually have it in the tables, because the code is printing entries only upon seeing the next character and if that character does have combining_value of 0 and flags are otherwise the same as previously printed, it will not print anything. The following patch fixes that, for clarity what exactly it affects I've regenerated with the same Unicode files as last time it has been regenerated. 2021-08-05 Jakub Jelinek <jakub@redhat.com> PR c++/100977 * makeucnid.c (write_table): Fix computation of last_combine. * ucnid.h: Regenerated using Unicode 6.3.0 files.
next prev parent reply other threads:[~2021-08-05 15:34 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-08 18:15 [Bug c++/100977] New: " jason at gcc dot gnu.org 2021-06-08 18:19 ` [Bug c++/100977] " mpolacek at gcc dot gnu.org 2021-08-04 13:39 ` jakub at gcc dot gnu.org 2021-08-04 14:08 ` jakub at gcc dot gnu.org 2021-08-04 16:14 ` jakub at gcc dot gnu.org 2021-08-04 18:34 ` joseph at codesourcery dot com 2021-08-04 18:40 ` jakub at gcc dot gnu.org 2021-08-04 19:06 ` ubizjak at gmail dot com 2021-08-04 19:20 ` jakub at gcc dot gnu.org 2021-08-04 19:25 ` ubizjak at gmail dot com 2021-08-05 10:17 ` jakub at gcc dot gnu.org 2021-08-05 15:34 ` cvs-commit at gcc dot gnu.org [this message] 2021-08-05 15:35 ` cvs-commit at gcc dot gnu.org 2021-09-01 20:37 ` cvs-commit at gcc dot gnu.org 2021-09-01 20:38 ` jakub at gcc dot gnu.org 2021-11-30 8:51 ` cvs-commit at gcc dot gnu.org 2021-12-01 9:22 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100977-4-x2HeAlvz52@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).