public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "bergner at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/101002] Some powerpc tests fail with -mlong-double-64
Date: Tue, 20 Jun 2023 21:20:43 +0000	[thread overview]
Message-ID: <bug-101002-4-gasJFGthOI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101002-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101002

Peter Bergner <bergner at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |linkw at gcc dot gnu.org
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2023-06-20

--- Comment #4 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Michael Meissner from comment #0)
> I now build GCC with all 3 long double variants (IEEE 128-bit, IBM 128-bit,
> and 64-bit).  The following C test fail when when you configure the compiler
> to use 64-bit long doubles:
> 
> gcc.dg/float128-align.c
> gcc.dg/float64x-align.c
> gcc.dg/tree-ssa/builtin-sprintf.c
> gcc.target/powerpc/convert-fp-64.c
> gcc.target/powerpc/float128-hw.c
> gcc.target/powerpc/float128-hw4.c
> gcc.target/powerpc/gnuattr2.c
> gcc.target/powerpc/gnuattr3.c
> gcc.target/powerpc/pr60203.c
> gcc.target/powerpc/pr79004.c
> gcc.target/powerpc/pr82748-1.c
> gcc.target/powerpc/pr85657-3.c
> gcc.target/powerpc/signbit-1.c


Currently, the following don't FAIL anymore or are correctly disabled from
running (a little of each reason):
gcc.dg/tree-ssa/builtin-sprintf.c
gcc.target/powerpc/convert-fp-64.c
gcc.target/powerpc/float128-hw.c
gcc.target/powerpc/gnuattr2.c
gcc.target/powerpc/gnuattr3.c
gcc.target/powerpc/pr60203.c
gcc.target/powerpc/pr79004.c
gcc.target/powerpc/pr82748-1.c

The rest still FAIL:

gcc.dg/float128-align.c
gcc.dg/float64x-align.c
floatn-align.h:17:1: error: static assertion failed: "max_align_t must be at
least as aligned as _Float* types"
   17 | _Static_assert (_Alignof (max_align_t) >= _Alignof (TYPE),

These die because the struct we're using to check the alignment of uses long
double as the "big" aligned type.  We could either disable the tests using a
"dg-require-effective-target longdouble128" or we could use a different more
aligned type in the struct.  Maybe _Float128 or _Decimal128 or use an attribute
aligned?   Thoughts?



gcc.target/powerpc/float128-hw4.c
float128-hw4.i: In function ‘get_float128_exponent’:
float128-hw4.i:10:3: error: invalid parameter combination for AltiVec intrinsic
‘__builtin_vec_scalar_extract_exp’
   10 |   return __builtin_vec_scalar_extract_exp (a);
      |   ^~~~~~
float128-hw4.i: In function ‘get_float128_mantissa’:
float128-hw4.i:22:3: error: invalid parameter combination for AltiVec intrinsic
‘__builtin_vec_scalar_extract_sig’
   22 |   return __builtin_vec_scalar_extract_sig (a);
      |   ^~~~~~
float128-hw4.i: In function ‘set_float128_exponent_float128’:
float128-hw4.i:46:3: error: invalid parameter combination for AltiVec intrinsic
‘__builtin_vec_scalar_insert_exp’
   46 |   return __builtin_vec_scalar_insert_exp (a, e);


The problem here seems to be we define overloaded double and _Float128 versions
of these builtins, but not a long double version.  With -mlong-double-128, we
seem to automatically emit a cast of 'a' to 'double' and everything is fine. 
However, when using -mlong-double-64, no implicit cast occurs and then we run
afoul of not having a long double version of the builtin.  I can explicitly add
a cast to double and then everything is fine.  Maybe the builtin harness can
just "accept" long double as double when using -mlong-double-64?



gcc.target/powerpc/pr85657-3.c
gcc.target/powerpc/signbit-1.c
pr85657-3.c:38:20: error: unknown type name ‘__ibm128’; did you mean
‘__int128’?

These die because we don't create the type __ibm128 when using
-mlong-double-64, which seems strange since we do create the __float128 type
used in the test cases.

Mike, I assume the __ibm128 type should always be created?

  parent reply	other threads:[~2023-06-20 21:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09 20:18 [Bug testsuite/101002] New: " meissner at gcc dot gnu.org
2021-06-10 15:17 ` [Bug testsuite/101002] " bergner at gcc dot gnu.org
2021-06-11 20:54 ` segher at gcc dot gnu.org
2021-06-11 20:55 ` segher at gcc dot gnu.org
2023-06-20 21:20 ` bergner at gcc dot gnu.org [this message]
2023-06-21 17:30 ` bergner at gcc dot gnu.org
2023-06-21 17:41 ` bergner at gcc dot gnu.org
2023-06-21 20:31 ` bergner at gcc dot gnu.org
2023-06-21 20:34 ` bergner at gcc dot gnu.org
2023-06-21 23:19 ` segher at gcc dot gnu.org
2023-06-22 13:49 ` dje at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101002-4-gasJFGthOI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).