From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 325F1383B424; Mon,  5 Jul 2021 20:42:06 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 325F1383B424
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101039] Some simple
 fold_cond_expr_with_comparison with CMP 0 is not simplified if expanded
Date: Mon, 05 Jul 2021 20:42:06 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: missed-optimization, patch
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-101039-4-sXuN7Aq4Ss@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-101039-4@http.gcc.gnu.org/bugzilla/>
References: <bug-101039-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Jul 2021 20:42:06 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101039

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:7d6979197274a662da7bdc564314afe8415865c1

commit r12-2041-g7d6979197274a662da7bdc564314afe8415865c1
Author: Andrew Pinski <apinski@marvell.com>
Date:   Sat Jun 12 19:45:20 2021 -0700

    Port most of the A CMP 0 ? A : -A to match

    To improve phiopt and be able to remove abs_replacement, this ports
    most of "A CMP 0 ? A : -A" from fold_cond_expr_with_comparison to
    match.pd.  There is a few extra changes that are needed to remove
    the "A CMP 0 ? A : -A" part from fold_cond_expr_with_comparison:
       * Need to handle (A - B) case
       * Need to handle UN* comparisons.

    I will handle those in a different patch.

    Note phi-opt-15.c test needed to be updated as we get ABSU now
    instead of not getting ABS.  When ABSU was added phiopt was not
    updated even to use ABSU instead of not creating ABS.

    OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.

    gcc/ChangeLog:

            PR tree-optimization/101039
            * match.pd (A CMP 0 ? A : -A): New patterns.
            * tree-ssa-phiopt.c (abs_replacement): Delete function.
            (tree_ssa_phiopt_worker): Don't call abs_replacement.
            Update comment about abs_replacement.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/101039
            * gcc.dg/tree-ssa/phi-opt-15.c: Update test to expect
            ABSU and still not expect ABS_EXPR.
            * gcc.dg/tree-ssa/phi-opt-23.c: New test.
            * gcc.dg/tree-ssa/phi-opt-24.c: New test.=