public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/101062] [10/11/12 Regression] wrong code with "-O2 -fno-toplevel-reorder -frename-registers"
Date: Wed, 16 Jun 2021 10:18:41 +0000	[thread overview]
Message-ID: <bug-101062-4-U9k2FIcciv@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101062-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101062

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b4b50bf2864e09f028a39a3f460222632c4d7348

commit r12-1527-gb4b50bf2864e09f028a39a3f460222632c4d7348
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jun 16 12:17:55 2021 +0200

    stor-layout: Create DECL_BIT_FIELD_REPRESENTATIVE even for bitfields in
unions [PR101062]

    The following testcase is miscompiled on x86_64-linux, the bitfield store
    is implemented as a RMW 64-bit operation at d+24 when the d variable has
    size of only 28 bytes and scheduling moves in between the R and W part
    a store to a different variable that happens to be right after the d
    variable.

    The reason for this is that we weren't creating
    DECL_BIT_FIELD_REPRESENTATIVEs for bitfields in unions.

    The following patch does create them, but treats all such bitfields as if
    they were in a structure where the particular bitfield is the only field.

    2021-06-16  Jakub Jelinek  <jakub@redhat.com>

            PR middle-end/101062
            * stor-layout.c (finish_bitfield_representative): For fields in
unions
            assume nextf is always NULL.
            (finish_bitfield_layout): Compute bit field representatives also in
            unions, but handle it as if each bitfield was the only field in the
            aggregate.

            * gcc.dg/pr101062.c: New test.

  parent reply	other threads:[~2021-06-16 10:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 11:05 [Bug tree-optimization/101062] New: " suochenyao at 163 dot com
2021-06-14 18:04 ` [Bug tree-optimization/101062] [10/11/12 Regression] " jakub at gcc dot gnu.org
2021-06-14 18:08 ` jakub at gcc dot gnu.org
2021-06-14 18:35 ` jakub at gcc dot gnu.org
2021-06-14 18:59 ` jakub at gcc dot gnu.org
2021-06-14 20:20 ` jakub at gcc dot gnu.org
2021-06-14 21:46 ` ebotcazou at gcc dot gnu.org
2021-06-15  7:42 ` rguenth at gcc dot gnu.org
2021-06-15  8:15 ` jakub at gcc dot gnu.org
2021-06-15  8:56 ` [Bug middle-end/101062] " rguenther at suse dot de
2021-06-15  9:05 ` jakub at gcc dot gnu.org
2021-06-15  9:21 ` rguenth at gcc dot gnu.org
2021-06-16 10:18 ` cvs-commit at gcc dot gnu.org [this message]
2021-06-17  8:20 ` jakub at gcc dot gnu.org
2021-06-17  8:22 ` jakub at gcc dot gnu.org
2021-06-17  9:13 ` ebotcazou at gcc dot gnu.org
2021-06-18  9:21 ` cvs-commit at gcc dot gnu.org
2021-06-18  9:23 ` cvs-commit at gcc dot gnu.org
2021-06-18  9:23 ` cvs-commit at gcc dot gnu.org
2021-07-13 13:13 ` [Bug middle-end/101062] [10 " jakub at gcc dot gnu.org
2022-05-10  8:18 ` cvs-commit at gcc dot gnu.org
2022-05-10  8:19 ` cvs-commit at gcc dot gnu.org
2022-05-11  6:20 ` cvs-commit at gcc dot gnu.org
2022-05-11  6:20 ` cvs-commit at gcc dot gnu.org
2022-05-11  6:36 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101062-4-U9k2FIcciv@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).