From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 39819385780B; Thu, 17 Jun 2021 07:29:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39819385780B From: "crazylht at gmail dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/101097] Vectorizer is too eager to use vec_unpack Date: Thu, 17 Jun 2021 07:29:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: normal X-Bugzilla-Who: crazylht at gmail dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jun 2021 07:29:22 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101097 --- Comment #6 from Hongtao.liu --- (In reply to Richard Biener from comment #5) > (In reply to Uro=C5=A1 Bizjak from comment #3) > > Created attachment 51031 [details] > > Pack/unpack patterns for 8-byte vectors > >=20 > > FYI, this patch adds pack/unpack patterns for 8-byte vectors. It will f= ail: > >=20 > > FAIL: gcc.target/i386/pr97249-1.c scan-assembler-times (?n)vpmovzxbw[ > > \\\\t]+\\\\(.*%xmm[0-9] 2 > > FAIL: gcc.target/i386/pr97249-1.c scan-assembler-times (?n)vpmovzxwd[ > > \\\\t]+\\\\(.*%xmm[0-9] 2 > >=20 > > due to the mentioned issue. >=20 > You can add #pragma GCC unroll 8/4 to "fix" that and add a comment this t= est > tests BB vectorization. Loop vectorization would have failed even before > the patch (and now succeeds, but with less optimal code). I just to want to classify the test is used to test another optimization wh= ich rely on either loop vectorization or slp. it means it's ok to add unroll pr= agma here.=