public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vincent-gcc at vinc17 dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/101125] New: warn when a construct would become invalid if a function were replaced by a function-like macro
Date: Fri, 18 Jun 2021 14:38:48 +0000	[thread overview]
Message-ID: <bug-101125-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101125

            Bug ID: 101125
           Summary: warn when a construct would become invalid if a
                    function were replaced by a function-like macro
           Product: gcc
           Version: 11.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: vincent-gcc at vinc17 dot net
  Target Milestone: ---

In the standard C library and some other libraries (like GNU MPFR), functions
may be replaced by function-like macros with the same behavior. So, in order to
detect potential portability issues, GCC should provide a warning to check
whether a construct used with a function call would become invalid if the
function were replaced by a macro.

Such a difference can at least come from the use of the comma in some
expressions. Example:

struct s { int a, b; };
void f (int);
#define F(X) f(X)
void g (void)
{
  f ((struct s){0,1}.a);
  F ((struct s){0,1}.a);
}

The call to f is valid, but the use of the macro yields an error because the
preprocessor assumes that there are 2 arguments in the call: "(struct s){0" and
"1}.a". Here, one should use additional parentheses:

  F (((struct s){0,1}.a));

AFAIK, the library (which provides the function and the macro in a header file)
cannot do anything to avoid such an error; only the user can avoid it, but he
may not be aware of the issue as long as only a function is provided. Hence the
usefulness of the proposed warning.

             reply	other threads:[~2021-06-18 14:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 14:38 vincent-gcc at vinc17 dot net [this message]
2021-06-18 17:00 ` [Bug c/101125] " pinskia at gcc dot gnu.org
2021-06-18 19:15 ` vincent-gcc at vinc17 dot net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101125-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).