public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101150] [11/12/13 Regression] null pointer dereference false positive disappears when compiling an additional function
Date: Thu, 23 Mar 2023 18:05:12 +0000	[thread overview]
Message-ID: <bug-101150-4-PFm4gLmwEk@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101150-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101150

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-bisection
      Known to work|                            |13.0

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
On the trunk, the warning is gone so is the missed optimization mentioned in
comment #1.

We do have another missed optimization though:
  _12 = _9 - _15;
  _7 = _12 /[ex] 4;
  _18 = (long unsigned int) _7;
  _120 = _18 != 0;
  _54 = _12 != 0;
  _127 = _54 & _120;
  if (_127 != 0)
    goto <bb 3>; [16.50%]
  else
    goto <bb 9>; [83.50%]
...
  <bb 9> [local count: 98623186]:
  if (_9 != _15)
    goto <bb 10>; [89.00%]
  else
    goto <bb 23>; [11.00%]

Only one of those comparisons is actually needed. and then another missing jump
threading because _9 be equal _15 on the goto <bb 9> branch.

  parent reply	other threads:[~2023-03-23 18:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 11:48 [Bug c++/101150] New: " adl at gnu dot org
2021-06-22  0:11 ` [Bug tree-optimization/101150] " pinskia at gcc dot gnu.org
2021-07-28  7:07 ` [Bug tree-optimization/101150] [11/12 Regression] " rguenth at gcc dot gnu.org
2022-01-20 12:55 ` rguenth at gcc dot gnu.org
2022-04-21  7:49 ` rguenth at gcc dot gnu.org
2023-03-23 18:05 ` pinskia at gcc dot gnu.org [this message]
2023-05-29 10:05 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101150-4-PFm4gLmwEk@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).