[Bug tree-optimization/101159] New: [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[Bug tree-optimization/101159] New: [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

            Bug ID: 101159
           Summary: [12 Regression] ICE Segmentation fault since
                    r12-1707-ge08a125b208e717f
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: crazylht at gmail dot com
  Target Milestone: ---

I see the following ICE:

$ cat bitmap.ii
unsigned long bitmap_single_bit_set_p_count;
long bitmap_single_bit_set_p_elt_0_0;
void bitmap_single_bit_set_p() {
  bitmap_single_bit_set_p_count +=
      __builtin_popcountl(bitmap_single_bit_set_p_elt_0_0);
}

$ g++ bitmap.ii -c -O3
during GIMPLE pass: slp
bitmap.ii: In function ‘void bitmap_single_bit_set_p()’:
bitmap.ii:3:6: internal compiler error: Segmentation fault
    3 | void bitmap_single_bit_set_p() {
      |      ^~~~~~~~~~~~~~~~~~~~~~~
0x117d266 crash_signal
        /home/marxin/Programming/gcc/gcc/toplev.c:327
0x7ffff786139f ???
        ../sysdeps/unix/sysv/linux/sigaction.c:10
0xefd333 tree_class_check(tree_node*, tree_code_class, char const*, int, char
const*)
        /home/marxin/Programming/gcc/gcc/tree.h:3493
0xefd333 direct_optab_supported_p
        /home/marxin/Programming/gcc/gcc/internal-fn.c:3533
0x1d47e57 vect_recog_popcount_pattern
        /home/marxin/Programming/gcc/gcc/tree-vect-patterns.c:1388
0x1d4b18a vect_pattern_recog_1
        /home/marxin/Programming/gcc/gcc/tree-vect-patterns.c:5584
0x1d52ae9 vect_pattern_recog(vec_info*)
        /home/marxin/Programming/gcc/gcc/tree-vect-patterns.c:5742
0x14429eb vect_slp_analyze_bb_1
        /home/marxin/Programming/gcc/gcc/tree-vect-slp.c:5561
0x14429eb vect_slp_region
        /home/marxin/Programming/gcc/gcc/tree-vect-slp.c:5669
0x1444a68 vect_slp_bbs
        /home/marxin/Programming/gcc/gcc/tree-vect-slp.c:5819
0x1444e64 vect_slp_function(function*)
        /home/marxin/Programming/gcc/gcc/tree-vect-slp.c:5905
0x144b35a execute
        /home/marxin/Programming/gcc/gcc/tree-vectorizer.c:1445
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
               Host|                            |x86_64-linux-gnu
             Status|UNCONFIRMED                 |NEW
   Target Milestone|---                         |12.0
           Priority|P3                          |P1
   Last reconfirmed|                            |2021-06-22

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zsojka at seznam dot cz

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 101161 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
A simple patch to check the return value of get_vectype_for_scalar_type to make
sure it is non-null should fix the testcase and return NULL.

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Will test that.

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:a5b773d3f86dd4333696cab0fe3a6953d3db74a3

commit r12-1714-ga5b773d3f86dd4333696cab0fe3a6953d3db74a3
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Jun 22 09:12:42 2021 +0200

    tree-optimization/101159 - fix missing NULL check in popcount pattern

    This fixes a missing check for a NULL vectype in the new popcount
    pattern.

    2021-06-22  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/101159
            * tree-vect-patterns.c (vect_recog_popcount_pattern): Add
            missing NULL vectype check.

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
No testcase for the testsuite?

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[rguenther at suse dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

--- Comment #7 from rguenther at suse dot de <rguenther at suse dot de> ---
On Tue, 22 Jun 2021, jakub at gcc dot gnu.org wrote:

> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159
> 
> Jakub Jelinek <jakub at gcc dot gnu.org> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |jakub at gcc dot gnu.org
> 
> --- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> No testcase for the testsuite?

It's unlikely to come back and the fix is quite obvious so I indeed
didn't bother ...

[Bug tree-optimization/101159] [12 Regression] ICE Segmentation fault since r12-1707-ge08a125b208e717f

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101159

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:3adb9ac6626c15ba21e4eaf27fec95688a3ca8c2

commit r12-1728-g3adb9ac6626c15ba21e4eaf27fec95688a3ca8c2
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jun 22 15:22:51 2021 +0200

    testsuite: Add testcase for recently fixed PR [PR101159]

    On Tue, Jun 22, 2021 at 11:00:51AM +0200, Richard Biener wrote:
    > 2021-06-22  Richard Biener  <rguenther@suse.de>
    >
    >       PR tree-optimization/101159
    >       * tree-vect-patterns.c (vect_recog_popcount_pattern): Add
    >       missing NULL vectype check.

    The following patch adds the testcase for it, IMHO it can't hurt and
    from my experience testcases often trigger other bugs later on (rather
    than the original bugs reappearing, though even that happens),
    and also fixes a couple of typos in the new function.

    2021-06-22  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/101159
            * tree-vect-patterns.c (vect_recog_popcount_pattern): Fix some
            comment typos.

            * gcc.c-torture/compile/pr101159.c: New test.