public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "crazylht at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/101185] pr96814.c failed after r12-1669 on non-avx512 platform
Date: Thu, 24 Jun 2021 01:56:38 +0000	[thread overview]
Message-ID: <bug-101185-4-jQ4pJMYWhP@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101185-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101185

--- Comment #3 from Hongtao.liu <crazylht at gmail dot com> ---
(In reply to Hongtao.liu from comment #1)
> Alloc order is just another kind of cost which can be compensated by
> increasing cost of mask->integer and integer->mask.
> 
> With below patch , pr96814 wouldn't generate any mask intructions execept
> for 
> 
> 	kmovd	%eax, %k1
> 	vpcmpeqd	%ymm1, %ymm1, %ymm1
> 	vmovdqu8	%ymm1, %ymm0{%k1}{z}
> 
> which is what we want.
> 
> 
> modified   gcc/config/i386/i386.md
> @@ -1335,7 +1335,7 @@
>  (define_insn "*cmp<mode>_ccz_1"
>    [(set (reg FLAGS_REG)
>  	(compare (match_operand:SWI1248_AVX512BWDQ_64 0
> -			"nonimmediate_operand" "<r>,?m<r>,$k")
> +			"nonimmediate_operand" "<r>,?m<r>,*k")
>  		 (match_operand:SWI1248_AVX512BWDQ_64 1 "const0_operand")))]
>    "TARGET_AVX512F && ix86_match_ccmode (insn, CCZmode)"
>    "@
> modified   gcc/config/i386/x86-tune-costs.h
> @@ -2768,7 +2768,7 @@ struct processor_costs intel_cost = {
>    {6, 6, 6, 6, 6},			/* cost of storing SSE registers
>  					   in 32,64,128,256 and 512-bit */
>    4, 4,				/* SSE->integer and integer->SSE moves */
> -  4, 4,				/* mask->integer and integer->mask moves */
> +  6, 6,				/* mask->integer and integer->mask moves */
I changed intel_cost just to validate 1 unit more cost is also enough for
-mtune=intel to prevent generation of mask instructions.

  parent reply	other threads:[~2021-06-24  1:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24  1:32 [Bug target/101185] New: pr96814 " crazylht at gmail dot com
2021-06-24  1:44 ` [Bug target/101185] " crazylht at gmail dot com
2021-06-24  1:52 ` crazylht at gmail dot com
2021-06-24  1:56 ` crazylht at gmail dot com [this message]
2021-06-24  6:01 ` [Bug target/101185] pr96814.c " ubizjak at gmail dot com
2021-06-24  6:44 ` [Bug target/101185] [12 Regression] " rguenth at gcc dot gnu.org
2021-06-24  7:08 ` ubizjak at gmail dot com
2021-06-24  7:14 ` crazylht at gmail dot com
2021-06-24  8:41 ` jakub at gcc dot gnu.org
2021-06-24  8:52 ` crazylht at gmail dot com
2021-06-24  9:12 ` ubizjak at gmail dot com
2021-06-24  9:18 ` crazylht at gmail dot com
2021-06-24  9:36 ` rguenth at gcc dot gnu.org
2021-06-24 12:13 ` hjl.tools at gmail dot com
2021-06-25  1:17 ` cvs-commit at gcc dot gnu.org
2021-07-14 12:10 ` cvs-commit at gcc dot gnu.org
2021-09-20  4:33 ` [Bug testsuite/101185] " pinskia at gcc dot gnu.org
2021-09-20  4:43 ` pinskia at gcc dot gnu.org
2021-09-20  4:47 ` [Bug target/101185] " pinskia at gcc dot gnu.org
2021-09-20  6:19 ` rguenther at suse dot de
2022-01-05  6:00 ` crazylht at gmail dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101185-4-jQ4pJMYWhP@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).