public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101207] New: [12 Regress] gcc.dg/vect/vect-strided-mult.c fails after SLP improvements
Date: Fri, 25 Jun 2021 09:44:44 +0000	[thread overview]
Message-ID: <bug-101207-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101207

            Bug ID: 101207
           Summary: [12 Regress] gcc.dg/vect/vect-strided-mult.c fails
                    after SLP improvements
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64-linux-gnu

So after the recent SLP improvements gcc.dg/vect/vect-strided-mult.c started to
fail on aarch64-linux-gnu .

There was one place where SLP happens where it did not happen before with:
....
|| ires[i].a != iarr[i].b - iarr[i].a
....
|| ires[i].b != iarr[i].b + iarr[i].a

Which produces in optimized:
  vect__22.39_7 = MEM <vector(2) unsigned int> [(unsigned int *)_101];
  _46 = BIT_FIELD_REF <vect__22.39_7, 32, 32>;
  _8 = BIT_FIELD_REF <vect__22.39_7, 32, 0>;
  _24 = _8 - _46;
...
  _47 = .REDUC_PLUS (vect__22.39_7);

In the assembly code:
-       ldr     d0, [x1]
-       umov    w8, v0.s[1]
-       fmov    w5, s0
-       sub     w5, w5, w8
....
-        addp    v0.2s, v0.2s, v0.2s

Where before we did:
+       ldp     w6, w3, [x1]
+       sub     w8, w3, w6
....
+       add     wN, w3, w6

The add should be ok but the subtraction I think is failing.

             reply	other threads:[~2021-06-25  9:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  9:44 pinskia at gcc dot gnu.org [this message]
2021-06-25  9:45 ` [Bug tree-optimization/101207] " pinskia at gcc dot gnu.org
2021-06-25  9:53 ` [Bug tree-optimization/101207] [12 Regress] gcc.dg/vect/vect-strided-*-mult.c " pinskia at gcc dot gnu.org
2021-06-25 10:07 ` [Bug tree-optimization/101207] [12 Regression] " pinskia at gcc dot gnu.org
2021-06-25 10:11 ` pinskia at gcc dot gnu.org
2021-06-28  6:54 ` rguenth at gcc dot gnu.org
2021-06-28  7:26 ` rguenth at gcc dot gnu.org
2021-06-28  7:45 ` rguenth at gcc dot gnu.org
2021-06-28  7:55 ` pinskia at gcc dot gnu.org
2021-06-28  8:35 ` cvs-commit at gcc dot gnu.org
2021-06-28  8:35 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101207-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).