* [Bug libstdc++/101228] #include <execution> triggers Intel TBB warning for tbb/task.h
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
@ 2021-06-27 2:49 ` kip at thevertigo dot com
2021-06-27 3:22 ` [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB pinskia at gcc dot gnu.org
` (15 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: kip at thevertigo dot com @ 2021-06-27 2:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #1 from Kip Warner <kip at thevertigo dot com> ---
Suggestion: Maybe a unit test that includes all the standard STL headers, does
nothing with them, and that's expected to emit no warnings would mitigate
problems like this occurring in the future.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
2021-06-27 2:49 ` [Bug libstdc++/101228] " kip at thevertigo dot com
@ 2021-06-27 3:22 ` pinskia at gcc dot gnu.org
2021-06-28 0:59 ` kip at thevertigo dot com
` (14 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-06-27 3:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|#include <execution> |tbb/task.h is Deprecated in
|triggers Intel TBB warning |newer TBB.
|for tbb/task.h |
Last reconfirmed| |2021-06-27
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
tbb/task.h just got deprecated last year and after parallel_backend_tbb.h was
added to GCC.
https://github.com/oneapi-src/oneTBB/issues/243
It depends on the version of TBB that is installed really. Looks like Ubuntu
11.1.0 is using a much newer version. You really should file a bug with Ubuntu
about this issue since you are getting both GCC and TBB from them. We won't
fixing Ubuntu's compiler even with this bug filed by the way.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
2021-06-27 2:49 ` [Bug libstdc++/101228] " kip at thevertigo dot com
2021-06-27 3:22 ` [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB pinskia at gcc dot gnu.org
@ 2021-06-28 0:59 ` kip at thevertigo dot com
2021-06-28 9:09 ` redi at gcc dot gnu.org
` (13 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: kip at thevertigo dot com @ 2021-06-28 0:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #3 from Kip Warner <kip at thevertigo dot com> ---
Thanks Andrew. I've opened an issue downstream:
https://bugs.launchpad.net/gcc/+bug/1933775
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (2 preceding siblings ...)
2021-06-28 0:59 ` kip at thevertigo dot com
@ 2021-06-28 9:09 ` redi at gcc dot gnu.org
2021-06-28 9:32 ` doko at debian dot org
` (12 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: redi at gcc dot gnu.org @ 2021-06-28 9:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |MOVED
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
<execution> requires TBB, as documented:
https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2017
"Note 3: The Parallel Algorithms have an external dependency on Intel TBB 2018
or later. If the <execution> header is included then -ltbb must be used to link
to TBB."
If you use the parallel algos (or just include their headers) then the TBB
headers are included. That's by design, they don't work otherwise. We can't do
anythign about the fact that Intel deprecated their own API shortly after using
contributing the PSTL headers to GCC, which depend on that API.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (3 preceding siblings ...)
2021-06-28 9:09 ` redi at gcc dot gnu.org
@ 2021-06-28 9:32 ` doko at debian dot org
2021-06-28 9:36 ` redi at gcc dot gnu.org
` (11 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: doko at debian dot org @ 2021-06-28 9:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
Matthias Klose <doko at debian dot org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |doko at debian dot org
--- Comment #5 from Matthias Klose <doko at debian dot org> ---
No, the gcc packages don't depend on any tbb package. Probably tbb needs an
update to a new upstream version in the distro.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (4 preceding siblings ...)
2021-06-28 9:32 ` doko at debian dot org
@ 2021-06-28 9:36 ` redi at gcc dot gnu.org
2021-06-28 11:47 ` pilarlatiesa at gmail dot com
` (10 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: redi at gcc dot gnu.org @ 2021-06-28 9:36 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
There's no easy solution. Intel contributed the PSTL headers with a dependency
on TBB task.h header, then deprecated that header in a later TBB release. You
need to either use an older TBB, or suppress the warning.
There is a plan to add an OpenMP backend to PSTL, which will remove the TBB
dependency, but it's not ready yet.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (5 preceding siblings ...)
2021-06-28 9:36 ` redi at gcc dot gnu.org
@ 2021-06-28 11:47 ` pilarlatiesa at gmail dot com
2021-06-28 13:29 ` redi at gcc dot gnu.org
` (9 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pilarlatiesa at gmail dot com @ 2021-06-28 11:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
Pilar Latiesa <pilarlatiesa at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pilarlatiesa at gmail dot com
--- Comment #7 from Pilar Latiesa <pilarlatiesa at gmail dot com> ---
This appears to be fixed upstream: https://reviews.llvm.org/D87380
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (6 preceding siblings ...)
2021-06-28 11:47 ` pilarlatiesa at gmail dot com
@ 2021-06-28 13:29 ` redi at gcc dot gnu.org
2021-06-28 17:23 ` rodgertq at gcc dot gnu.org
` (8 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: redi at gcc dot gnu.org @ 2021-06-28 13:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|MOVED |---
Status|RESOLVED |NEW
CC| |rodgertq at gcc dot gnu.org
--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Tom, it looks like that fix landed upstream after our last sync. Should we use
it?
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (7 preceding siblings ...)
2021-06-28 13:29 ` redi at gcc dot gnu.org
@ 2021-06-28 17:23 ` rodgertq at gcc dot gnu.org
2022-05-27 9:01 ` pilarlatiesa at gmail dot com
` (7 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: rodgertq at gcc dot gnu.org @ 2021-06-28 17:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
Thomas Rodgers <rodgertq at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |rodgertq at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #9 from Thomas Rodgers <rodgertq at gcc dot gnu.org> ---
Yes (I already reviewed it when it arrived upstream). It is probably also safe
to backport to GCC-11 since there's no ABI or ABI stability concerns. I will
have a go at applying *just* this patch (I don't want to commit to trying a
full rebase against upstream at this point).
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (8 preceding siblings ...)
2021-06-28 17:23 ` rodgertq at gcc dot gnu.org
@ 2022-05-27 9:01 ` pilarlatiesa at gmail dot com
2022-05-27 10:03 ` redi at gcc dot gnu.org
` (6 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: pilarlatiesa at gmail dot com @ 2022-05-27 9:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #10 from Pilar Latiesa <pilarlatiesa at gmail dot com> ---
I believe this was fixed for 11.2
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (9 preceding siblings ...)
2022-05-27 9:01 ` pilarlatiesa at gmail dot com
@ 2022-05-27 10:03 ` redi at gcc dot gnu.org
2022-10-30 14:13 ` hicham at mouline dot org
` (5 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: redi at gcc dot gnu.org @ 2022-05-27 10:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Known to work| |11.1.0
--- Comment #11 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes, it was fixed by r11-4187 but the problem is still present on the gcc-10
branch.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (10 preceding siblings ...)
2022-05-27 10:03 ` redi at gcc dot gnu.org
@ 2022-10-30 14:13 ` hicham at mouline dot org
2022-11-18 20:10 ` kerukuro at gmail dot com
` (4 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: hicham at mouline dot org @ 2022-10-30 14:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
hicham at mouline dot org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hicham at mouline dot org
--- Comment #12 from hicham at mouline dot org ---
I see this warning still in g++ (GCC) 12.2.1 20220819 (Red Hat 12.2.1-2) with
tbb-2020.3-9.fc35.x86_64
In file included from /usr/include/c++/12/pstl/parallel_backend_tbb.h:26,
from /usr/include/c++/12/pstl/parallel_backend.h:20,
from /usr/include/c++/12/pstl/algorithm_impl.h:22,
from /usr/include/c++/12/pstl/glue_execution_defs.h:50,
from /usr/include/c++/12/execution:32,
from 4.cpp:8:
/usr/include/tbb/task.h:21:139: note: ‘#pragma message: TBB Warning: tbb/task.h
is deprecated. For details, please see Deprecated Features appendix in the TBB
reference manual.’
21 | #pragma message("TBB Warning: tbb/task.h is deprecated. For details,
please see Deprecated Features appendix in the TBB reference manual.")
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (11 preceding siblings ...)
2022-10-30 14:13 ` hicham at mouline dot org
@ 2022-11-18 20:10 ` kerukuro at gmail dot com
2023-02-16 11:24 ` redi at gcc dot gnu.org
` (3 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: kerukuro at gmail dot com @ 2022-11-18 20:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
kerukuro <kerukuro at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kerukuro at gmail dot com
--- Comment #13 from kerukuro <kerukuro at gmail dot com> ---
Yes, this issue is not fixed.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (12 preceding siblings ...)
2022-11-18 20:10 ` kerukuro at gmail dot com
@ 2023-02-16 11:24 ` redi at gcc dot gnu.org
2023-06-27 14:48 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
16 siblings, 0 replies; 18+ messages in thread
From: redi at gcc dot gnu.org @ 2023-02-16 11:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #14 from Jonathan Wakely <redi at gcc dot gnu.org> ---
N.B. you can use -DTBB_SUPPRESS_DEPRECATED_MESSAGES=1 to suppress the warning.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (13 preceding siblings ...)
2023-02-16 11:24 ` redi at gcc dot gnu.org
@ 2023-06-27 14:48 ` redi at gcc dot gnu.org
2024-02-29 11:27 ` redi at gcc dot gnu.org
2024-03-19 16:00 ` cvs-commit at gcc dot gnu.org
16 siblings, 0 replies; 18+ messages in thread
From: redi at gcc dot gnu.org @ 2023-06-27 14:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #15 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #11)
> Yes, it was fixed by r11-4187 but the problem is still present on the gcc-10
> branch.
I think that commit simply makes it possible to use oneTBB, which doesn't give
a warning. But if you use TBB 2020.3 or older, then you still get a warning.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (14 preceding siblings ...)
2023-06-27 14:48 ` redi at gcc dot gnu.org
@ 2024-02-29 11:27 ` redi at gcc dot gnu.org
2024-03-19 16:00 ` cvs-commit at gcc dot gnu.org
16 siblings, 0 replies; 18+ messages in thread
From: redi at gcc dot gnu.org @ 2024-02-29 11:27 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #16 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Maybe we could do something like this:
--- a/libstdc++-v3/include/pstl/parallel_backend_tbb.h
+++ b/libstdc++-v3/include/pstl/parallel_backend_tbb.h
@@ -15,6 +15,11 @@
#include "parallel_backend_utils.h"
+#ifndef TBB_SUPPRESS_DEPRECATED_MESSAGES
+# define TBB_SUPPRESS_DEPRECATED_MESSAGES 1
+# define _GLIBCXX_UNDEF_SUPPRESS
+#endif
+
// Bring in minimal required subset of Intel TBB
#include <tbb/blocked_range.h>
#include <tbb/parallel_for.h>
@@ -25,6 +30,11 @@
#include <tbb/tbb_allocator.h>
#include <tbb/task.h>
+#ifdef _GLIBCXX_UNDEF_SUPPRESS
+# undef TBB_SUPPRESS_DEPRECATED_MESSAGES
+# undef _GLIBCXX_UNDEF_SUPPRESS
+#endif
+
#if TBB_INTERFACE_VERSION < 10000
# error Intel(R) Threading Building Blocks 2018 is required; older versions
are not supported.
#endif
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Bug libstdc++/101228] tbb/task.h is Deprecated in newer TBB.
2021-06-27 1:13 [Bug libstdc++/101228] New: #include <execution> triggers Intel TBB warning for tbb/task.h kip at thevertigo dot com
` (15 preceding siblings ...)
2024-02-29 11:27 ` redi at gcc dot gnu.org
@ 2024-03-19 16:00 ` cvs-commit at gcc dot gnu.org
16 siblings, 0 replies; 18+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-19 16:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101228
--- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:c608b57f77a47179899666940c3b8b6a2e5435b2
commit r14-9550-gc608b57f77a47179899666940c3b8b6a2e5435b2
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Feb 29 17:13:49 2024 +0000
libstdc++: Suppress deprecation messages from <tbb/task.h> [PR101228]
libstdc++-v3/ChangeLog:
PR libstdc++/101228
* include/pstl/parallel_backend_tbb.h
(TBB_SUPPRESS_DEPRECATED_MESSAGES):
Define before including <tbb/task.h> then undef afterwards.
^ permalink raw reply [flat|nested] 18+ messages in thread