From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 1D408385BF93; Tue, 29 Jun 2021 15:09:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D408385BF93 From: "amacleod at redhat dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/101254] [12 Regression] gcc head does not comply fully to -fwrapv since r12-1723 Date: Tue, 29 Jun 2021 15:09:58 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: amacleod at redhat dot com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 12.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 15:09:59 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101254 --- Comment #2 from Andrew Macleod --- Created attachment 51082 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D51082&action=3Dedit patch I *think* this is correct. but wrapv and signed stuff sometimes confuses = me :-) when -fwrapv is on, +INf - -INF is -1 ? is this correct? in which case, the relations that were being added for minus were not quite correct in this case. given lhs =3D op1 - op2 if op1 > op2, we were producing a range of [1, +INF]. which is fine for unsigned. but for signed, that edge condition for -INF means the range sh= ould be [0, +INF]. likewise, if op1 >=3D op2, then result range would be [0, +INF] Is this is correct? I hope that -INF - -INF still equals 0 tho? Thats t= he only other case that might need consideration. The attached patch implements the above and appears to fix the test. I just want to be sure I have it right.=