public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101272] [12 Regression] error: ‘nonnull’ argument ‘message’ compared to NULL [-Werror=nonnull-compare] since r12-1805
Date: Wed, 30 Jun 2021 15:30:59 +0000	[thread overview]
Message-ID: <bug-101272-4-1FA3YVKkLc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101272-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101272

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12 Regression] error:      |[12 Regression] error:
                   |‘nonnull’ argument          |‘nonnull’ argument
                   |‘message’ compared to NULL  |‘message’ compared to NULL
                   |[-Werror=nonnull-compare]   |[-Werror=nonnull-compare]
                   |since                       |since r12-1805
           Keywords|                            |diagnostic

--- Comment #1 from Martin Sebor <msebor at gcc dot gnu.org> ---
The warning is valid and expected.  It started to be issued with r12-1805. 
Prior to that, the parentheses around the inequality expression suppressed it,
like so:

$ cat t.C && cc1plus.r12-1804 -quiet -Wall -Werror -o/dev/null t.C
__attribute__ ((nonnull)) void
f (int *p) { p == 0 ? __builtin_abort () : (void)0; }

__attribute__ ((nonnull)) void
g (int *p) { (p == 0) ? __builtin_abort () : (void)0; }

t.C: In function ‘void f(int*)’:
t.C:2:21: error: ‘nonnull’ argument ‘p’ compared to NULL
[-Werror=nonnull-compare]
    2 | f (int *p) { p == 0 ? __builtin_abort () : (void)0; }
      |              ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus.r12-1804: all warnings being treated as errors

  reply	other threads:[~2021-06-30 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 14:50 [Bug tree-optimization/101272] New: [12 Regression] error: ‘nonnull’ argument ‘message’ compared to NULL [-Werror=nonnull-compare] since marxin at gcc dot gnu.org
2021-06-30 15:30 ` msebor at gcc dot gnu.org [this message]
2021-07-01  7:16 ` [Bug tree-optimization/101272] [12 Regression] error: ‘nonnull’ argument ‘message’ compared to NULL [-Werror=nonnull-compare] since r12-1805 rguenth at gcc dot gnu.org
2021-07-01  7:19 ` marxin at gcc dot gnu.org
2021-07-01 14:38 ` msebor at gcc dot gnu.org
2021-07-01 14:43 ` marxin at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101272-4-1FA3YVKkLc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).