public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/101297] Spurious comma accepted at the end of #pragma omp atomic
Date: Fri, 02 Jul 2021 19:58:58 +0000	[thread overview]
Message-ID: <bug-101297-4-fjwQ5QsjHZ@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101297-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101297

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2ca89394280da4afad6074ec3cb7136b6142af7b

commit r12-1990-g2ca89394280da4afad6074ec3cb7136b6142af7b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jul 2 21:57:24 2021 +0200

    openmp: Reject #pragma omp atomic update, [PR101297]

    I've noticed that we allow a trailing comma on OpenMP atomic construct
    if there is at least one clause.  Commas should be only allowed to
    separate the clauses (or in OpenMP 5.1 to separate directive name
    from the clauses).

    2021-07-02  Jakub Jelinek  <jakub@redhat.com>

            PR c/101297
            * c-parser.c (c_parser_omp_atomic): Consume comma only if it
            appears before a CPP_NAME.

            * parser.c (cp_parser_omp_atomic): Consume comma only if it
            appears before a CPP_NAME.

            * c-c++-common/gomp/atomic-24.c: New test.

      parent reply	other threads:[~2021-07-02 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-02 12:22 [Bug c/101297] New: " jakub at gcc dot gnu.org
2021-07-02 12:23 ` [Bug c/101297] " jakub at gcc dot gnu.org
2021-07-02 12:29 ` jakub at gcc dot gnu.org
2021-07-02 19:58 ` cvs-commit at gcc dot gnu.org [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101297-4-fjwQ5QsjHZ@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).