From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 2F97F3838022; Fri,  2 Jul 2021 19:58:58 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F97F3838022
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c/101297] Spurious comma accepted at the end of #pragma omp
 atomic
Date: Fri, 02 Jul 2021 19:58:58 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-101297-4-fjwQ5QsjHZ@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-101297-4@http.gcc.gnu.org/bugzilla/>
References: <bug-101297-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Jul 2021 19:58:58 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101297

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2ca89394280da4afad6074ec3cb7136b6142af7b

commit r12-1990-g2ca89394280da4afad6074ec3cb7136b6142af7b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jul 2 21:57:24 2021 +0200

    openmp: Reject #pragma omp atomic update, [PR101297]

    I've noticed that we allow a trailing comma on OpenMP atomic construct
    if there is at least one clause.  Commas should be only allowed to
    separate the clauses (or in OpenMP 5.1 to separate directive name
    from the clauses).

    2021-07-02  Jakub Jelinek  <jakub@redhat.com>

            PR c/101297
            * c-parser.c (c_parser_omp_atomic): Consume comma only if it
            appears before a CPP_NAME.

            * parser.c (cp_parser_omp_atomic): Consume comma only if it
            appears before a CPP_NAME.

            * c-c++-common/gomp/atomic-24.c: New test.=