public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101335] [12 Regression] wrong code at -O2 and above (casts between signed and unsigned) by r12-1796
Date: Mon, 12 Jul 2021 15:35:21 +0000	[thread overview]
Message-ID: <bug-101335-4-Sj0HEGB299@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101335-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101335

--- Comment #2 from Andrew Macleod <amacleod at redhat dot com> ---
yeah, it because we have been treating casts to objects of the same precision
as equivalences.    This normally works fine, but in this case we have
c_9 = (int)_2          c_9 == _2
_3 = c_9 - 10      so  _3 is < c_9
d_10 = (unsigned)_3    d_10 == _3 

if (_2 < d_10)
with the equivalences, it now thinks that d_10 < _2.

So I have to either not allow compounding relations thru casting equivalences
(painful), or something else.

-fwrapv make its work because we don't register the relation _3 < c_9 if
wrapping is on.


I'm running an experiment... When the recomputation code was introduced, it
completely eliminated the need to track downcasts. It seems that removing all
equivalences between casts doesn't miss anything either, so perhaps this older
bit isn't needed anymore.

I'm running it thru the testsuite now...

  parent reply	other threads:[~2021-07-12 15:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-05 19:01 [Bug tree-optimization/101335] New: wrong code at -Os and above on x86_64-linux-gnu zhendong.su at inf dot ethz.ch
2021-07-05 19:25 ` [Bug tree-optimization/101335] wrong code at -O2 and above pinskia at gcc dot gnu.org
2021-07-05 19:26 ` [Bug tree-optimization/101335] [12 Regression] wrong code at -O2 and above (casts between signed and unsigned) pinskia at gcc dot gnu.org
2021-07-06  6:42 ` [Bug tree-optimization/101335] [12 Regression] wrong code at -O2 and above (casts between signed and unsigned) by r12-1796 rguenth at gcc dot gnu.org
2021-07-12 15:35 ` amacleod at redhat dot com [this message]
2021-07-12 18:37 ` cvs-commit at gcc dot gnu.org
2021-07-12 18:38 ` amacleod at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101335-4-Sj0HEGB299@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).