[Bug target/101395] New: Compile failure with -march=native -m32 on sapphirerapids

[Bug target/101395] New: Compile failure with -march=native -m32 on sapphirerapids

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

            Bug ID: 101395
           Summary: Compile failure with -march=native -m32 on
                    sapphirerapids
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: wwwhhhyyy333 at gmail dot com
  Target Milestone: ---

cat test.c

int main()
{
   return 0;
}

On sapphire rapids machine,

gcc test.c -march=native -m32

will get 

cc1: error: ‘-muintr’ not supported for 32-bit code

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.2
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
           Assignee|unassigned at gcc dot gnu.org      |hjl.tools at gmail dot com
   Last reconfirmed|                            |2021-07-09

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 51124
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51124&action=edit
A patch

Please test this patch.

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #2 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
(In reply to H.J. Lu from comment #1)
> Created attachment 51124 [details]
> A patch
> 
> Please test this patch.

It doesn't work.

I use ./sde-external-8.63.0-2021-01-18-lin/sde -spr -- gcc test.c -march=native
-m32 to verify it.

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51124|0                           |1
        is obsolete|                            |

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 51125
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51125&action=edit
An updated patch

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #4 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
(In reply to H.J. Lu from comment #3)
> Created attachment 51125 [details]
> An updated patch

This works, thanks.

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Wouldn't it work to instead wrap the -muintr option from local_cpu_detect into
%{m64|mx32:-muintr} or %{!m32:-muintr} depending on TARGET_64BIT_DEFAULT ?
-muintr-native is ugly...

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51125|0                           |1
        is obsolete|                            |

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 51142
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51142&action=edit
A patch

Please try this.

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Comment on attachment 51142
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51142
A patch

Can't you use one single local_cpu_detect and pass it 2 arguments (arch/tune
and 32/64) instead of just one (arch/tune)?
Then you could check that second arg only for the uintr...

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #8 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Jakub Jelinek from comment #7)
> Comment on attachment 51142 [details]
> A patch
> 
> Can't you use one single local_cpu_detect and pass it 2 arguments (arch/tune
> and 32/64) instead of just one (arch/tune)?
> Then you could check that second arg only for the uintr...

I can and host_detect_local_cpu needs to parse "arch32/tune32/arch64/tune64".

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51142|0                           |1
        is obsolete|                            |

--- Comment #9 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 51143
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51143&action=edit
A patch

Try this instead.

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[wwwhhhyyy333 at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #10 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
(In reply to H.J. Lu from comment #9)
> Created attachment 51143 [details]
> A patch
> 
> Try this instead.

This also works.

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #11 from H.J. Lu <hjl.tools at gmail dot com> ---
The v3 patch is posted at

https://gcc.gnu.org/pipermail/gcc-patches/2021-July/575102.html

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:cc11b924bfe7752edbba052ca71653f46a60887a

commit r12-2296-gcc11b924bfe7752edbba052ca71653f46a60887a
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Jul 9 09:16:01 2021 -0700

    x86: Don't enable UINTR in 32-bit mode

    UINTR is available only in 64-bit mode.  Since the codegen target is
    unknown when the the gcc driver is processing -march=native, to properly
    handle UINTR for -march=native:

    1. Pass "arch [32|64]" and "tune [32|64]" to host_detect_local_cpu to
    indicate 32-bit and 64-bit codegen.
    2. Change ix86_option_override_internal to enable UINTR only in 64-bit
    mode for -march=CPU when PTA_CPU includes PTA_UINTR.

    gcc/

            PR target/101395
            * config/i386/driver-i386.c (host_detect_local_cpu): Check
            "arch [32|64]" and "tune [32|64]" for 32-bit and 64-bit codegen.
            Enable UINTR only for 64-bit codegen.
            * config/i386/i386-options.c
            (ix86_option_override_internal::DEF_PTA): Skip PTA_UINTR if not
            in 64-bit mode.
            * config/i386/i386.h (ARCH_ARG): New.
            (CC1_CPU_SPEC): Pass "[arch|tune] 32" for 32-bit codegen and
            "[arch|tune] 64" for 64-bit codegen.

    gcc/testsuite/

            PR target/101395
            * gcc.target/i386/pr101395-1.c: New test.
            * gcc.target/i386/pr101395-2.c: Likewise.
            * gcc.target/i386/pr101395-3.c: Likewise.

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:a0128f11e9dadc3cc3ed0ad0edb36593b16f72e8

commit r11-8754-ga0128f11e9dadc3cc3ed0ad0edb36593b16f72e8
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Fri Jul 9 09:16:01 2021 -0700

    x86: Don't enable UINTR in 32-bit mode

    UINTR is available only in 64-bit mode.  Since the codegen target is
    unknown when the the gcc driver is processing -march=native, to properly
    handle UINTR for -march=native:

    1. Pass "arch [32|64]" and "tune [32|64]" to host_detect_local_cpu to
    indicate 32-bit and 64-bit codegen.
    2. Change ix86_option_override_internal to enable UINTR only in 64-bit
    mode for -march=CPU when PTA_CPU includes PTA_UINTR.

    gcc/

            PR target/101395
            * config/i386/driver-i386.c (host_detect_local_cpu): Check
            "arch [32|64]" and "tune [32|64]" for 32-bit and 64-bit codegen.
            Enable UINTR only for 64-bit codegen.
            * config/i386/i386-options.c
            (ix86_option_override_internal::DEF_PTA): Skip PTA_UINTR if not
            in 64-bit mode.
            * config/i386/i386.h (ARCH_ARG): New.
            (CC1_CPU_SPEC): Pass "[arch|tune] 32" for 32-bit codegen and
            "[arch|tune] 64" for 64-bit codegen.

    gcc/testsuite/

            PR target/101395
            * gcc.target/i386/pr101395-1.c: New test.
            * gcc.target/i386/pr101395-2.c: Likewise.
            * gcc.target/i386/pr101395-3.c: Likewise.

    (cherry picked from commit cc11b924bfe7752edbba052ca71653f46a60887a)

[Bug target/101395] [11/12 regression] Compile failure with -march=native -m32 on sapphirerapids

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101395

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed for GCC 12 and 11.2.