public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "doodspav at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/101439] New: std::atomic<__uint128_t>::load() crashes - possible fix with mutable Date: Tue, 13 Jul 2021 15:43:18 +0000 [thread overview] Message-ID: <bug-101439-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101439 Bug ID: 101439 Summary: std::atomic<__uint128_t>::load() crashes - possible fix with mutable Product: gcc Version: 4.8.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ Assignee: unassigned at gcc dot gnu.org Reporter: doodspav at gmail dot com Target Milestone: --- The following code will cause a segfault on x86 from g++4.8 up to g++11.1 (currently the latest non-trunk version on Godbolt): ``` #include <atomic> struct S { long i, j; }; const std::atomic<S> x{ {0, 0} }; int f(const std::atomic<S>* p) { S y = *p; return y.i; } int main() { return f(&x); } ``` (demonstrated here: https://godbolt.org/z/eWcTv5fdY for however long the link remains alive) Loading the value from `x` causes libatomic to use `lock cmpxchg16b` on read-only memory, crashing the program (since `lock cmpxchg16b` always performs a write). This has been reported in bug report 95722 (and touched upon in 70490), however those treat it as a libatomic bug (which it technically is), whereas here I seek to treat it as a libstdc++ bug. A "simple" workaround for C++ that doesn't involve changing anything in libatomic would be to mark all members in any 16 byte specialisation of `std::atomic` as `mutable`, preventing the compiler from placing it in read-only memory. This is what MSVC does in their implementation (as does Boost.Atomic I think). This shouldn't break anything as far as I can tell. This code (using `_Atomic`) also causes a segfault in C. I can't really think of a similar fix there (maybe just act as if DR459 never happened?).
next reply other threads:[~2021-07-13 15:43 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-13 15:43 doodspav at gmail dot com [this message] 2021-08-28 20:55 ` [Bug libstdc++/101439] std::atomic<sixteen_byte_struct>::load() " pinskia at gcc dot gnu.org 2021-08-28 21:10 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-101439-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).