public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/101460] Useless cascade of overload resolution errors for invalid expression
Date: Thu, 15 Jul 2021 15:26:02 +0000	[thread overview]
Message-ID: <bug-101460-4-2ibYBYghYc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101460-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101460

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:17855eed7fc76b2cee7fbbc26f84d3c8b99be13c

commit r12-2327-g17855eed7fc76b2cee7fbbc26f84d3c8b99be13c
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Jul 14 20:14:14 2021 +0100

    libstdc++: Fix std::get<T> for std::tuple [PR101427]

    The std::get<T> functions relied on deduction failing if more than one
    base class existed for the type T.  However the implementation of Core
    DR 2303 (in r11-4693) made deduction succeed (and select the
    more-derived base class).

    This rewrites the implementation of std::get<T> to explicitly check for
    more than one occurrence of T in the tuple elements, making it
    ill-formed again. Additionally, the large wall of overload resolution
    errors described in PR c++/101460 is avoided by making std::get<T> use
    __get_helper<I> directly instead of calling std::get<I>, and by adding a
    deleted overload of __get_helper<N> for out-of-range N.

    Signed-off-by: Jonathan Wakely <jwakely@redhat.com>

    libstdc++-v3/ChangeLog:

            PR libstdc++/101427
            * include/std/tuple (tuple_element): Improve static_assert text.
            (__get_helper): Add deleted overload.
            (get<i>(tuple<T...>&&), get<i>(const tuple<T...>&&)): Use
            __get_helper directly.
            (__get_helper2): Remove.
            (__find_uniq_type_in_pack): New constexpr helper function.
            (get<T>): Use __find_uniq_type_in_pack and __get_helper instead
            of __get_helper2.
            * testsuite/20_util/tuple/element_access/get_neg.cc: Adjust
            expected errors.
            * testsuite/20_util/tuple/element_access/101427.cc: New test.

  parent reply	other threads:[~2021-07-15 15:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-15 11:11 [Bug c++/101460] New: " redi at gcc dot gnu.org
2021-07-15 11:58 ` [Bug c++/101460] " redi at gcc dot gnu.org
2021-07-15 12:04 ` redi at gcc dot gnu.org
2021-07-15 15:26 ` cvs-commit at gcc dot gnu.org [this message]
2021-07-19 12:38 ` cvs-commit at gcc dot gnu.org
2021-08-30 13:45 ` jason at gcc dot gnu.org
2021-08-30 21:23 ` cvs-commit at gcc dot gnu.org
2021-08-30 21:29 ` jason at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101460-4-2ibYBYghYc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).