public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/101482] New: The resolution of #32907 is too restricted
@ 2021-07-17 3:10 de34 at live dot cn
2022-06-16 6:07 ` [Bug libstdc++/101482] " de34 at live dot cn
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: de34 at live dot cn @ 2021-07-17 3:10 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101482
Bug ID: 101482
Summary: The resolution of #32907 is too restricted
Product: gcc
Version: 11.1.1
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: de34 at live dot cn
Target Milestone: ---
The resolution of bug #32907 is restricted to a few specializations
(basic_string<CharT>, where bool(__is_char<CharT>::value) is true).
It seems that the resolution should be generalized to all specializations of
basic_string (by removing the legacy operator== overload and SFINAE in the new
overload, which is already done by libc++ and msvc stl). IMO the generalized
resolution can also be applied to operator== for __versa_string.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/101482] The resolution of #32907 is too restricted
2021-07-17 3:10 [Bug libstdc++/101482] New: The resolution of #32907 is too restricted de34 at live dot cn
@ 2022-06-16 6:07 ` de34 at live dot cn
2022-06-16 9:47 ` [Bug libstdc++/101482] operator== for basic_string and __versa_string should check sizes first redi at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: de34 at live dot cn @ 2022-06-16 6:07 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101482
--- Comment #1 from Jiang An <de34 at live dot cn> ---
Partially fixed together with bug #62187.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/101482] operator== for basic_string and __versa_string should check sizes first
2021-07-17 3:10 [Bug libstdc++/101482] New: The resolution of #32907 is too restricted de34 at live dot cn
2022-06-16 6:07 ` [Bug libstdc++/101482] " de34 at live dot cn
@ 2022-06-16 9:47 ` redi at gcc dot gnu.org
2022-06-16 19:20 ` cvs-commit at gcc dot gnu.org
2022-06-16 19:22 ` redi at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: redi at gcc dot gnu.org @ 2022-06-16 9:47 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101482
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2022-06-16
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Ever confirmed|0 |1
Status|UNCONFIRMED |ASSIGNED
--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jiang An from comment #0)
> It seems that the resolution should be generalized to all specializations of
> basic_string (by removing the legacy operator== overload and SFINAE in the
> new overload, which is already done by libc++ and msvc stl).
Yes, https://wg21.link/lwg2852 clarified that we can do that.
> IMO the
> generalized resolution can also be applied to operator== for __versa_string.
Yes I'll do that, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/101482] operator== for basic_string and __versa_string should check sizes first
2021-07-17 3:10 [Bug libstdc++/101482] New: The resolution of #32907 is too restricted de34 at live dot cn
2022-06-16 6:07 ` [Bug libstdc++/101482] " de34 at live dot cn
2022-06-16 9:47 ` [Bug libstdc++/101482] operator== for basic_string and __versa_string should check sizes first redi at gcc dot gnu.org
@ 2022-06-16 19:20 ` cvs-commit at gcc dot gnu.org
2022-06-16 19:22 ` redi at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-06-16 19:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101482
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:51309d1158b85560a975819260776c0ca68fd142
commit r13-1138-g51309d1158b85560a975819260776c0ca68fd142
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Jun 16 11:02:11 2022 +0100
libstdc++: Apply r13-1096-g6abe341558abec change to vstring too [PR101482]
As recently done for std::basic_string, __gnu_cxx::__versa_string
equality comparisons can check lengths first for any character type and
traits type, not only for std::char_traits<char>.
libstdc++-v3/ChangeLog:
PR libstdc++/101482
* include/ext/vstring.h (operator==): Always check lengths
before comparing.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug libstdc++/101482] operator== for basic_string and __versa_string should check sizes first
2021-07-17 3:10 [Bug libstdc++/101482] New: The resolution of #32907 is too restricted de34 at live dot cn
` (2 preceding siblings ...)
2022-06-16 19:20 ` cvs-commit at gcc dot gnu.org
@ 2022-06-16 19:22 ` redi at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: redi at gcc dot gnu.org @ 2022-06-16 19:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101482
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |13.0
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed now, thanks for the report.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-16 19:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-17 3:10 [Bug libstdc++/101482] New: The resolution of #32907 is too restricted de34 at live dot cn
2022-06-16 6:07 ` [Bug libstdc++/101482] " de34 at live dot cn
2022-06-16 9:47 ` [Bug libstdc++/101482] operator== for basic_string and __versa_string should check sizes first redi at gcc dot gnu.org
2022-06-16 19:20 ` cvs-commit at gcc dot gnu.org
2022-06-16 19:22 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).