From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id A02CD3889C32; Mon, 19 Jul 2021 12:35:54 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A02CD3889C32
From: "enometh at meer dot net" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/101510] New: std::filesystem::create_directory  on an
 existing symlink to a directory
Date: Mon, 19 Jul 2021 12:35:54 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 11.1.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: enometh at meer dot net
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-101510-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Jul 2021 12:35:54 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101510

            Bug ID: 101510
           Summary: std::filesystem::create_directory  on an existing
                    symlink to a directory
           Product: gcc
           Version: 11.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: enometh at meer dot net
  Target Milestone: ---

cppreference.com states

```=20=20=20=20=20
bool create_directory( const std::filesystem::path& p );

Creates the directory p as if by POSIX mkdir() with a second argument of
static_cast<int>(std::filesystem::perms::all) (the parent directory must
already exist). If the function fails because p resolves to an existing
directory, no error is reported. Otherwise on failure an error is reported.
```

This should accomodate situations when `p' resolves to an existing directory
when `p' it is a symbolic link.

However create_directory(p) fails when p is a symbolic link which points
to an existing directory.

The standard usage pattern is to call mkdir(p) - and if it fails on EEXIST
to stat(2) p - following symlinks, and check if is a directory. The pattern
is used to ensure that `p' can be treated as a directory for further
operations and this includes p being a symbolic link to a directory)

This use of pattern is defeated if user code is replaced with a call to
std::create_directory without considering the symlink following
semantics of the pattern. (eg. replacing glib g_mkdir_with_parents with
std::fs::create_directories)

I think libstdc++ follow symlinks when resolving names for the create_direc=
tory
and create_directory functions.=