public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/101537] -Wconversion false positive in ternary and |= Date: Fri, 31 Dec 2021 22:34:21 +0000 [thread overview] Message-ID: <bug-101537-4-NJ9UPCSjGs@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-101537-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101537 Jakub Jelinek <jakub at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Created attachment 52105 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52105&action=edit gcc12-pr101537.patch Untested fix. The PR101537 is fixed by this in both C and C++, PR103881 only in C; for C++ we end up with a COMPOUND_EXPR with TARGET_EXPR and then BIT_IOR_EXPR of something and the TARGET_EXPR_DECL. We'd need to remember when looking through COMPOUND_EXPRs if they don't have TARGET_EXPRs on the lhs and if so, remember for conversion_warning the mapping from their TARGET_EXPR_DECLs to those TARGET_EXPRs, so that we could then look those up. But it seems unsafe_conversion_p has some BIT_*_EXPR handling code, so that would need to be copied over into conversion_warning too. Or perhaps alternatively we could change unsafe_conversion_p to handle whatever is missing in there (SAVE_EXPRs, TARGET_EXPRs etc.).
next prev parent reply other threads:[~2021-12-31 22:34 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-20 17:41 [Bug c++/101537] New: -Wconversion false positive in ternary me at xenu dot pl 2021-08-08 15:15 ` [Bug c++/101537] " nok.raven at gmail dot com 2021-08-12 23:47 ` [Bug c/101537] -Wconversion false positive in ternary and |= pinskia at gcc dot gnu.org 2021-12-31 17:25 ` thomas at habets dot se 2021-12-31 22:34 ` jakub at gcc dot gnu.org [this message] 2022-01-03 11:52 ` jakub at gcc dot gnu.org 2022-01-11 18:15 ` cvs-commit at gcc dot gnu.org 2022-01-24 9:21 ` cvs-commit at gcc dot gnu.org 2022-05-10 8:22 ` cvs-commit at gcc dot gnu.org 2023-06-29 15:31 ` wolter.hellmundvega at tevva dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-101537-4-NJ9UPCSjGs@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).