public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c++/101589] New: Incorrect implementation of LWG 3533 for elements_view
@ 2021-07-23 2:21 ensadc at mailnesia dot com
2021-07-23 3:46 ` [Bug libstdc++/101589] " ppalka at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: ensadc at mailnesia dot com @ 2021-07-23 2:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101589
Bug ID: 101589
Summary: Incorrect implementation of LWG 3533 for elements_view
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c++
Assignee: unassigned at gcc dot gnu.org
Reporter: ensadc at mailnesia dot com
CC: ppalka at gcc dot gnu.org
Target Milestone: ---
LWG 3533 changed the const& overload of `elements_view::iterator::base` to
return a const reference, but it seems that g:eb1aa9ad incorrectly applied the
change to `elements_view::base` (that is, the `base()` member of the *view*,
when it's supposed to change the member of the *iterator*).
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/101589] Incorrect implementation of LWG 3533 for elements_view
2021-07-23 2:21 [Bug c++/101589] New: Incorrect implementation of LWG 3533 for elements_view ensadc at mailnesia dot com
@ 2021-07-23 3:46 ` ppalka at gcc dot gnu.org
2021-08-02 19:30 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: ppalka at gcc dot gnu.org @ 2021-07-23 3:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101589
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |10.4
Last reconfirmed| |2021-07-23
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |ppalka at gcc dot gnu.org
Status|UNCONFIRMED |ASSIGNED
--- Comment #1 from Patrick Palka <ppalka at gcc dot gnu.org> ---
D'oh... mine.
We also need to apply LWG 3533 to lazy_split_view::_InnerIter, which I
overlooked in r12-1662.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/101589] Incorrect implementation of LWG 3533 for elements_view
2021-07-23 2:21 [Bug c++/101589] New: Incorrect implementation of LWG 3533 for elements_view ensadc at mailnesia dot com
2021-07-23 3:46 ` [Bug libstdc++/101589] " ppalka at gcc dot gnu.org
@ 2021-08-02 19:30 ` cvs-commit at gcc dot gnu.org
2021-10-12 18:09 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-08-02 19:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101589
--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:4414057186b227edf5b5efa527732bfcdf39d575
commit r12-2675-g4414057186b227edf5b5efa527732bfcdf39d575
Author: Patrick Palka <ppalka@redhat.com>
Date: Mon Aug 2 15:30:13 2021 -0400
libstdc++: Fix up implementation of LWG 3533 [PR101589]
In r12-569 I accidentally applied the LWG 3533 change to
elements_view::iterator::base instead to elements_view::base.
This patch corrects this, and also applies the corresponding LWG 3533
change to lazy_split_view::inner-iter::base now that we implement P2210.
PR libstdc++/101589
libstdc++-v3/ChangeLog:
* include/std/ranges (lazy_split_view::_InnerIter::base): Make
the const& overload unconstrained and return a const reference
as per LWG 3533. Make unconditionally noexcept.
(elements_view::base): Revert accidental r12-569 change.
(elements_view::_Iterator::base): Make the const& overload
unconstrained and return a const reference as per LWG 3533.
Make unconditionally noexcept.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/101589] Incorrect implementation of LWG 3533 for elements_view
2021-07-23 2:21 [Bug c++/101589] New: Incorrect implementation of LWG 3533 for elements_view ensadc at mailnesia dot com
2021-07-23 3:46 ` [Bug libstdc++/101589] " ppalka at gcc dot gnu.org
2021-08-02 19:30 ` cvs-commit at gcc dot gnu.org
@ 2021-10-12 18:09 ` cvs-commit at gcc dot gnu.org
2021-10-12 18:38 ` cvs-commit at gcc dot gnu.org
2021-10-12 18:39 ` ppalka at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-12 18:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101589
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:d187dfbd038a9be68ceb81a6ce4125d50cb453f9
commit r11-9131-gd187dfbd038a9be68ceb81a6ce4125d50cb453f9
Author: Patrick Palka <ppalka@redhat.com>
Date: Mon Aug 2 15:30:13 2021 -0400
libstdc++: Fix up implementation of LWG 3533 [PR101589]
In r12-569 I accidentally applied the LWG 3533 change to
elements_view::iterator::base instead to elements_view::base.
This patch corrects this, and also applies the corresponding LWG 3533
change to lazy_split_view::inner-iter::base now that we implement P2210.
PR libstdc++/101589
libstdc++-v3/ChangeLog:
* include/std/ranges (lazy_split_view::_InnerIter::base): Make
the const& overload unconstrained and return a const reference
as per LWG 3533. Make unconditionally noexcept.
(elements_view::base): Revert accidental r12-569 change.
(elements_view::_Iterator::base): Make the const& overload
unconstrained and return a const reference as per LWG 3533.
Make unconditionally noexcept.
(cherry picked from commit 4414057186b227edf5b5efa527732bfcdf39d575)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/101589] Incorrect implementation of LWG 3533 for elements_view
2021-07-23 2:21 [Bug c++/101589] New: Incorrect implementation of LWG 3533 for elements_view ensadc at mailnesia dot com
` (2 preceding siblings ...)
2021-10-12 18:09 ` cvs-commit at gcc dot gnu.org
@ 2021-10-12 18:38 ` cvs-commit at gcc dot gnu.org
2021-10-12 18:39 ` ppalka at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-12 18:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101589
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Patrick Palka
<ppalka@gcc.gnu.org>:
https://gcc.gnu.org/g:ac987e1e9b7679c550e6a02a3a47737609cf1462
commit r10-10202-gac987e1e9b7679c550e6a02a3a47737609cf1462
Author: Patrick Palka <ppalka@redhat.com>
Date: Mon Aug 2 15:30:13 2021 -0400
libstdc++: Fix up implementation of LWG 3533 [PR101589]
In r12-569 I accidentally applied the LWG 3533 change to
elements_view::iterator::base instead to elements_view::base.
This patch corrects this, and also applies the corresponding LWG 3533
change to lazy_split_view::inner-iter::base now that we implement P2210.
PR libstdc++/101589
libstdc++-v3/ChangeLog:
* include/std/ranges (lazy_split_view::_InnerIter::base): Make
the const& overload unconstrained and return a const reference
as per LWG 3533. Make unconditionally noexcept.
(elements_view::base): Revert accidental r12-569 change.
(elements_view::_Iterator::base): Make the const& overload
unconstrained and return a const reference as per LWG 3533.
Make unconditionally noexcept.
(cherry picked from commit 4414057186b227edf5b5efa527732bfcdf39d575)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/101589] Incorrect implementation of LWG 3533 for elements_view
2021-07-23 2:21 [Bug c++/101589] New: Incorrect implementation of LWG 3533 for elements_view ensadc at mailnesia dot com
` (3 preceding siblings ...)
2021-10-12 18:38 ` cvs-commit at gcc dot gnu.org
@ 2021-10-12 18:39 ` ppalka at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: ppalka at gcc dot gnu.org @ 2021-10-12 18:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101589
Patrick Palka <ppalka at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #5 from Patrick Palka <ppalka at gcc dot gnu.org> ---
Fixed for GCC 10.4/11.3/12
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-12 18:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-23 2:21 [Bug c++/101589] New: Incorrect implementation of LWG 3533 for elements_view ensadc at mailnesia dot com
2021-07-23 3:46 ` [Bug libstdc++/101589] " ppalka at gcc dot gnu.org
2021-08-02 19:30 ` cvs-commit at gcc dot gnu.org
2021-10-12 18:09 ` cvs-commit at gcc dot gnu.org
2021-10-12 18:38 ` cvs-commit at gcc dot gnu.org
2021-10-12 18:39 ` ppalka at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).