[Bug c/101626] New: [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376

[Bug c/101626] New: [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101626

            Bug ID: 101626
           Summary: [12 Regression] ICE in verify_sra_access_forest, at
                    tree-sra.c:2376
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Changed between 20210502 and 20210509.
(gcc configured with --enable-checking=yes)

Affects a bunch of testsuite files at -O1+,
e.g. pr36373*.c, pr39120.c, pr50444.c :


$ cat pr39120.c
struct X { int *p; } x;

struct X __attribute__((noinline))
foo(int *p) { struct X x; x.p = p; return x; }

void __attribute((noinline))
bar() { *x.p = 1; }

extern void abort (void);
int main()
{
  int i = 0;
  x = foo(&i);
  bar();
  if (i != 1)
    abort ();
  return 0;
}


$ gcc-12-20210725 -c pr39120.c -O2 -fsso-struct=big-endian
during GIMPLE pass: esra
pr39120.c: In function 'foo':
pr39120.c:18:1: internal compiler error: in verify_sra_access_forest, at
tree-sra.c:2376
   18 | }
      | ^
0xee585c verify_sra_access_forest(access*)
        ../../gcc/tree-sra.c:2376
0xee5af1 verify_all_sra_access_forests()
        ../../gcc/tree-sra.c:2420
0xee9d45 analyze_all_variable_accesses
        ../../gcc/tree-sra.c:3480
0xeea7c6 perform_intra_sra
        ../../gcc/tree-sra.c:4564

[Bug tree-optimization/101626] [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101626

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|c                           |tree-optimization
                 CC|                            |pinskia at gcc dot gnu.org
   Target Milestone|---                         |12.0

[Bug tree-optimization/101626] [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376

[jamborm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101626

Martin Jambor <jamborm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-07-27
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Martin Jambor <jamborm at gcc dot gnu.org> ---
Confirmed.  I will have a look (although probably unfortunately only later in
August).

[Bug tree-optimization/101626] [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376 since r12-622-ge2bc5b6c04df8200

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101626

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org,
                   |                            |marxin at gcc dot gnu.org
            Summary|[12 Regression] ICE in      |[12 Regression] ICE in
                   |verify_sra_access_forest,   |verify_sra_access_forest,
                   |at tree-sra.c:2376          |at tree-sra.c:2376 since
                   |                            |r12-622-ge2bc5b6c04df8200

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-622-ge2bc5b6c04df8200.

[Bug tree-optimization/101626] [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101626

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ebotcazou at gcc dot gnu.org
            Summary|[12 Regression] ICE in      |[12 Regression] ICE in
                   |verify_sra_access_forest,   |verify_sra_access_forest,
                   |at tree-sra.c:2376 since    |at tree-sra.c:2376
                   |r12-622-ge2bc5b6c04df8200   |
                 CC|ebotcazou at gcc dot gnu.org       |
             Status|NEW                         |ASSIGNED

--- Comment #3 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Fixing.

[Bug tree-optimization/101626] [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101626

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>:

https://gcc.gnu.org/g:4e3129b0caceec008a940aa5eada253cd0f0b3ec

commit r12-2755-g4e3129b0caceec008a940aa5eada253cd0f0b3ec
Author: Eric Botcazou <ebotcazou@gcc.gnu.org>
Date:   Thu Aug 5 10:21:30 2021 +0200

    Fix oversight in handling of reverse SSO in SRA pass

    The scalar storage order does not apply to pointer and vector components.

    gcc/
            PR tree-optimization/101626
            * tree-sra.c (propagate_subaccesses_from_rhs): Do not set the
            reverse scalar storage order on a pointer or vector component.

    gcc/testsuite/
            * gcc.dg/sso-15.c: New test.

[Bug tree-optimization/101626] [12 Regression] ICE in verify_sra_access_forest, at tree-sra.c:2376

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101626

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
Thanks for reporting the problem.